Univention Bugzilla – Bug 39779
Multi-edit throws traceback
Last modified: 2015-11-10 16:48:57 CET
Probably due to the changes with Bug 38190, the multi-edit feature does currently not work and shows a traceback. +++ This bug was initially created as a clone of Bug #38190 +++ If I open a user on demo.univention.de, it took between 2 to 4 seconds. A user should be opened in less than a second.
The problem here is that it is not considered that it can only be determined whether the multi edit mode needs to be activated when the given ldapName for DetailPage has been resolved (this can be a Deferred): > postMixInProperties: function() { > ... > this._multiEdit = this.ldapName instanceof Array; > ... > } There are multiple positions in the DetailPage class that rely on this._multiEdit, so it needs a careful evaluation how the logic mentioned above can be integrated here. Probably not too complicated, but this needs a bit of time. I would thus vote for an Erratum.
*** Bug 39819 has been marked as a duplicate of this bug. ***
Created attachment 7264 [details] patch patch: drop the pre-rendered detail page if detailpage is going to be opened in multi-edit mode. It seems the easiest thing to do. Otherwise I have 2 other patches which 1. creates a detailpage for each mode (normal, multi-edit-mode) or 2. which calls buildRendering when we know if we are in multi edit mode. I guess 2 would revert the performance enhancement (not sure). So the attached patch seems to be reasonable?!
(In reply to Florian Best from comment #3) > Created attachment 7264 [details] > patch > > patch: drop the pre-rendered detail page if detailpage is going to be opened > in multi-edit mode. > It seems the easiest thing to do. Otherwise I have 2 other patches which 1. > creates a detailpage for each mode (normal, multi-edit-mode) or 2. which > calls buildRendering when we know if we are in multi edit mode. > I guess 2 would revert the performance enhancement (not sure). > So the attached patch seems to be reasonable?! I think the solution in your patch is just fine as I assume that a multi-edit action is not called very frequently. (BTW, we are not able to determine in our Piwik statistics between normal and multi-edit action.)
I have addressed the following problems: * Ignore pre-rendered detail page for multi-edit operations * Only pre-render detail page for users/user flavor * Make sure that a pre-rendered detail page is properly destroyed (e.g., when creating a new user) * Correct problems when creating a new object in AD member mode * Remove margin below search form Commits for 4.0-3 erratum: univention-management-console-module-udm (5.1.25-95): r65332 | Bug #39779: correct various problems with pre-rendered detail page 2015-11-09-univention-management-console-module-udm.yaml: r65333 | Bug #39779: added YAML file Changes have been committed to 4.1-0, as well: univention-management-console-module-udm (6.0.9-1): r65334 | Bug #39779: correct various problems with pre-rendered detail page
I forgot to add another patch which broke the creation of group/share objects. 2015-11-09-univention-management-console-module-udm.yaml: r65339 | Bug #39779: adjusted package version in YAML file univention-management-console-module-udm (5.1.25-96): r65338 | Bug #39779: Fix error when creating a share or group UDM object univention-management-console-module-udm (6.0.9-2): r65337 | Bug #39779: Fix error when creating a share or group UDM object
*** Bug 39823 has been marked as a duplicate of this bug. ***
As discussed I tested the following cases: UCS 4.0-3 udm 5.1.25-95.627.201511091610 / 5.1.25-96.630.201511091727 (1) Opening a user is still fast OK - opening Administrator took ~ 400ms (2) MultiEdit (e.g. selected 3 users) OK - works again (3) Creating a new user should not create an abandoned DetailPage OK - Creating a new destroys the detailPage before creating a new one, so no more abandoned Pages (4) Opening a udm module that is not users/user should not preload a DetailPage OK - no preloaded DetailPage for groups / computers / printers / shares ... (5) Fix Traceback for new user and share if ad/member=true OK - created a new user OK - create 3 new shares and tried multi-editing (6) Create object OK - created 6 users OK - created 3 Groups OK - created DNS forward and reverse zone OK - YAML file
<http://errata.software-univention.de/ucs/4.0/363.html>