Bug 39825 - UVMMd fails to start for vvfat
UVMMd fails to start for vvfat
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Virtualization - UVMM
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-0-errata
Assigned To: Philipp Hahn
Erik Damrose
:
: 40026 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-09 11:24 CET by Philipp Hahn
Modified: 2015-11-26 15:18 CET (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Patch src/univention/uvmm/node.py (1.08 KB, text/plain)
2015-11-09 11:24 CET, Philipp Hahn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2015-11-09 11:24:53 CET
Created attachment 7266 [details]
Patch src/univention/uvmm/node.py

Traceback (most recent call last):
  File "/usr/sbin/univention-virtual-machine-manager-daemon", line 311, in <module>
    node_add(uri)
  File "/usr/lib/pymodules/python2.7/univention/uvmm/node.py", line 823, in add
    node = Node(uri, cache_dir=self.cache_dir)
  File "/usr/lib/pymodules/python2.7/univention/uvmm/node.py", line 522, in __init__
    domStat = Domain(xml, self)
  File "/usr/lib/pymodules/python2.7/univention/uvmm/node.py", line 197, in __init__
    self.xml2obj(domain)
  File "/usr/lib/pymodules/python2.7/univention/uvmm/node.py", line 348, in xml2obj
    dev.driver_type = driver.attrib['type']
  File "lxml.etree.pyx", line 2198, in lxml.etree._Attrib.__getitem__ (src/lxml/lxml.etree.c:49115)
KeyError: 'type'


According to /usr/share/libvirt/schemas/domaincommon.rng:1577 all attributes are optional:
1535   <define name="diskDriver">
1536     <element name="driver">
1537       <optional>
1538         <ref name="driverFormat"/>
...
1567   <define name="driverFormat">
1568     <attribute name="name">
1569       <ref name="genericName"/>    
1570     </attribute>
1571     <optional>
1572       <attribute name='type'>
Comment 1 Philipp Hahn univentionstaff 2015-11-19 07:35:21 CET
*** Bug 40026 has been marked as a duplicate of this bug. ***
Comment 2 Philipp Hahn univentionstaff 2015-11-20 18:31:12 CET
r65828 | Bug #39825 uvmm: /domain/devices/disk/driver/@type is optional

Package: univention-virtual-machine-manager-daemon
Version: 5.0.1-5.608.201511201824
Branch: ucs_4.1-0
Scope: errata4.1-0

r65834 | Bug #39825,Bug #39242,Bug #33982: uvmm YAML
 univention-virtual-machine-manager-daemon.yaml
Comment 3 Erik Damrose univentionstaff 2015-11-23 16:34:20 CET
OK: Code change
OK: Tests, type element optional
OK: YAML
Verified
Comment 4 Janek Walkenhorst univentionstaff 2015-11-26 15:18:28 CET
<http://errata.software-univention.de/ucs/4.1/7.html>