Bug 39910 – The UMC menu help dialogs are not displayed correctly

Bug 39910 - The UMC menu help dialogs are not displayed correctly


Summary:	The UMC menu help dialogs are not displayed correctly

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.1-4-errata
Assigned To:	Johannes Keiser
QA Contact:	Alexander Kläser

URL:
Keywords:

Depends on:
Blocks:	43084
	Show dependency tree / graph

Reported:	2015-11-12 13:49 CET by Alexander Kläser
Modified:	2019-02-21 11:13 CET (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?:	5: Will affect all installed domains
How will those affected feel about the bug?:	1: Nuisance – not a big deal but noticeable
User Pain:	0.029
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Design
Max CVSS v3 score:

Flags:	klaeser: Patch_Available+

Attachments
Screenshot of UMC help dialog (206.78 KB, image/png) 2015-11-12 13:49 CET, Alexander Kläser	Details
proposed_patch (423 bytes, patch) 2016-07-29 17:46 CEST, Johannes Keiser	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2015-11-12 13:49:03 CET

Created attachment 7291 [details]
Screenshot of UMC help dialog

... see attached screenshot, the bottom border is not displayed correctly.

Comment 1 Johannes Keiser

2016-07-29 17:46:41 CEST

Created attachment 7849 [details]
proposed_patch

The help dialog buttons use float right. They are taken out of the element flow aka the parent does not contain the button anymore hence the lacking background.

proposed_patch:
Use a pseudo block element after floated buttons.
Pseudo element has 'clear: both' attribute which prevents it from floating around float elements essentially containing all floated buttons within the parent element again.

Comment 2 Alexander Kläser

2016-11-21 11:25:19 CET

Please commit the patch.

Comment 3 Johannes Keiser

2016-11-25 16:37:37 CET

r 74741
univention-management-console-frontend-theme (1.0.4-6) 
* Bug #39910: Fix display error of UMC help dialogs

r 74742 | 1.0.4-7.117.201611251629
univention-management-console-frontend-theme (1.0.4-7) 
* Bug #39910: Version bump because of UCS 4.1-1

YAML: r 74743

Comment 4 Johannes Keiser

2016-11-25 18:13:23 CET

UCS 4.2 merge
r 74748 | 1.0.2-13A~4.2.0.201611251803
univention-web (1.0.2-13) 
* Bug #39910: Fix display error of UMC help dialogs

Comment 5 Alexander Kläser

2016-12-01 10:52:29 CET

Changes: OK, looks fine now in different browser. The patch would have been better integrated into umc-frontend package in the umc/app.css file. But this is OK for now.
YAML file: OK
Merge to 4.2-0: OK

→ VERIFIED