Bug 39974 - Appliance mode: Reload popup after clicking on finish
Appliance mode: Reload popup after clicking on finish
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: System setup
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-0-errata
Assigned To: Florian Best
Jürn Brodersen
:
Depends on:
Blocks: 40006
  Show dependency treegraph
 
Reported: 2015-11-16 16:42 CET by Erik Damrose
Modified: 2015-12-09 16:47 CET (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Firefox popup (33.37 KB, image/png)
2015-11-16 16:42 CET, Erik Damrose
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Damrose univentionstaff 2015-11-16 16:42:47 CET
Created attachment 7303 [details]
Firefox popup

In Appliance mode: After clicking on finish, the cleanup_pre scripts are executed - the last step is to restart umc-server and -web-server.
The cleanup_post scripts now do the rest, like stopping the browser and rebooting the system.
If the cleanup_post step takes more than ~10 seconds, a popup shows up in firefox, see screenshot.
It does not matter if you click it or not, as after some time a script will stop firefox and system setup is completed. However, this is not a very nice user experience.
Comment 1 Erik Damrose univentionstaff 2015-11-16 16:58:51 CET
The listener and notifier restart took to long and caused the popup
Comment 2 Erik Damrose univentionstaff 2015-11-17 09:41:37 CET
Also happened in EC2. I did not click on the Reload button and was redirected to the UMC login page after a short time. It is unclear what happens if Reload is clicked...
Comment 3 Florian Best univentionstaff 2015-11-17 21:25:44 CET
This wouldn't have happened if we used the suggested patch at Bug 38455 comment 2 ^^.
Comment 4 Florian Best univentionstaff 2015-11-17 21:27:52 CET
The patch is easy: add this in ApplianceWizard.js: tools.status('ignorePageReload', true)
Comment 5 Florian Best univentionstaff 2015-11-17 21:39:23 CET
I will apply this patch next week when Jürn is back.

diff --git a/base/univention-system-setup/umc/js/setup/ApplianceWizard.js b/base/univention-system-setup/umc/js/setup/ApplianceWizard.js
index 2a40361..82f97b1 100644
--- a/base/univention-system-setup/umc/js/setup/ApplianceWizard.js
+++ b/base/univention-system-setup/umc/js/setup/ApplianceWizard.js
@@ -2047,6 +2047,9 @@ define([
                                // being adjusted in 40_ssl/10ssl (cf., Bug #38455)
                                tools.checkSession(false);
 
+                               // make sure no page reload is requested
+                               tools.status('ignorePageReload', true);
+
                                // send save command to server
                                this._progressBar.reset(_('Initialize the configuration process ...'));
                                this.standby(true, this._progressBar);
Comment 6 Alexander Kläser univentionstaff 2015-11-18 17:12:53 CET
It would be more robust to wait explicitly for the UMC restart with actively checking the UMC connection (we do this when rebooting a system).
Comment 7 Florian Best univentionstaff 2015-11-23 16:13:46 CET
univention-system-setup (9.0.2-10):
r65852 | Bug #39974: don't display reload pop up on success page

univention-system-setup.yaml:
r65853 | YAML Bug #39974 Bug #39156
Comment 8 Janek Walkenhorst univentionstaff 2015-12-09 16:47:56 CET
<http://errata.software-univention.de/ucs/4.1/26.html>