Bug 40005 - App Center cancels update if no packages are affected
App Center cancels update if no packages are affected
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-1-errata
Assigned To: Florian Best
Dirk Wiesenthal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-17 21:25 CET by Dirk Wiesenthal
Modified: 2016-03-02 13:25 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2015-11-17 21:25:28 CET
Some apps ship packages that are only installed on a subset of app installations. If those (and only those) packages are updated in a new version of an app, those systems that do not have them installed cannot update the app:

The frontend asks the backend for the changes in a dry_run call. The dry_run yields "nothing to do" as no packages are to be updated. So the frontend cancels the process without saying "whatever, set the component!"

This results in the App still marked as to-be-updated as the component is not set to the newest version.

Note that on the command line, this is easy to fix. This is a frontend problem due to the dry_run.
Comment 1 Florian Best univentionstaff 2015-11-17 21:34:21 CET
The dry-run seems to need some re-thinking. Bug #38396.
Comment 2 Florian Best univentionstaff 2016-02-25 06:57:13 CET
dry_run must always return can_continue = False otherwise the page which shows the changes is not shown. Now this page is shown which tells 'No package changes' but offers to continue. (Are you okay with that sentence, otherwise I can replace it by 'No package changes are going to happen but the app meta information gets updated.' or something like this.

univention-appcenter (5.0.20-7):
r67671 | Bug #40005: don't stop installation/upgrading if no package changes are going to happen

univention-appcenter.yaml:
r67672 | YAML Bug #40005
Comment 3 Dirk Wiesenthal univentionstaff 2016-03-01 03:16:22 CET
Works great. Wording is fine until we get feedback stating otherwise.

YAML: OK
Comment 4 Janek Walkenhorst univentionstaff 2016-03-02 13:25:58 CET
<http://errata.software-univention.de/ucs/4.1/123.html>