Univention Bugzilla – Bug 40160
Screenshot in ini file is ignored in UCS 4.1
Last modified: 2016-02-11 14:02:20 CET
In UCS 4.1, the ini file should contain a variable called Thumbnails=. But the code says that while it is deprecated, Screenshot= is still supported. There is even a method get_screenshot_url.
But while the value is actually sent to the frontend, it is not stored anywhere. The frontend does not show the screenshot in absence of thumbnails.
1. Fix frontend, show screenshot
2. Fix backend, remove screenshot
I vote for 2.
(In reply to Dirk Wiesenthal from comment #0)
> I vote for 2.
Output of univention-app dev-populate-appcenter --help:
> -s SCREENSHOT [SCREENSHOT ...], --screenshot SCREENSHOT [SCREENSHOT ...]
> Path to a screenshot. Needs to be mentioned in INI as
> Screenshot=.... If the screenshot is localised
> (Screenshot= in [de]), two screenshots should be given
> -t THUMBNAILS [THUMBNAILS ...], --thumbnails THUMBNAILS [THUMBNAILS ...]
> Path to Thumbnails. Need to be mentioned in INI as
> Thumbnails=.... If the thumbnails are localised
> (Thumbnails= in [de]), two first [en], then [de]
> Thumbnails should be given
As there are other comments for options that are only available for 4.1/4.0, it would be helpful. BTW, I do not understand the description for the thumbnails option, "two first [en], then [de] Thumbnails should be given". Is this correct, that the first 2 thumbs are Englisch and the rest German? Or does it mean it is alternating?
I would vote for removing screenshot from udm/handlers/appcenter/app.py as it is obsolete in any way. The schema file will be left untouched.
I spotted two screenshot entries:
> $ grep -i '^screenshot=' $(find meta-inf/4.1/ -name \*.ini)
Could you have a look or open a ticket for these?
Otherwise the changes seem to be fine. I could create apps via univention-app dev-populate-appcenter with screenshots (for UCS 4.0).
Documentation adapted, screenshot removed from UDM in
(In reply to Alexander Kläser from comment #3)
> I spotted two screenshot entries:
> > $ grep -i '^screenshot=' $(find meta-inf/4.1/ -name \*.ini)
> > meta-inf/4.1/self-service/self-service_20151117.ini:Screenshot=self-service_screenshot.jpg
> > meta-inf/4.1/filewave/filewave_20151023.ini:Screenshot=filewave_screenshot.png
> Could you have a look or open a ticket for these?
Self Service: Renamed Screenshot to Thumbnails
Filewave: A new ini file will replace this one. Currently Test App Center only
(In reply to Dirk Wiesenthal from comment #4)
> Documentation adapted, screenshot removed from UDM in
> univention-appcenter 5.0.19-54.111.201602101312
Changes: OK, looks good now, I am happy :) .
YAML file: OK
(In reply to Dirk Wiesenthal from comment #5)
> Self Service: Renamed Screenshot to Thumbnails
> Filewave: A new ini file will replace this one. Currently Test App Center