Bug 40346 – Improve reliability of sysvol-sync

Bug 40346 - Improve reliability of sysvol-sync


Summary:	Improve reliability of sysvol-sync

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba4
Version:	UCS 4.0
Hardware:	Other Linux

Importance:	P3 normal (vote)
Target Milestone:	UCS 4.0-4-errata
Assigned To:	Arvid Requate
QA Contact:	Felix Botner

URL:
Keywords:

Depends on:	40186
Blocks:	42097
	Show dependency tree / graph

Reported:	2015-12-28 16:18 CET by Stefan Gohmann
Modified:	2016-08-23 14:47 CEST (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Troubleshooting
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stefan Gohmann

2015-12-28 16:18:58 CET

Please provide a 4.0-4-errata backport.

+++ This bug was initially created as a clone of Bug #40186 +++

There has been at least one report of broken fACLs in sysvol. The primary suspect is sysvol-sync. There might be issues coming from concurrent reads from and writes to /var/lib/samba/sysvol. There are at least threee ideas on how to improve this:

a) Lock the sysvol while operating on it (e.g. man flock)
b) First check with "rsync -au --dry-run" if copying is required at all
c) Generate a consistent sysvol copy for the reading rsync processes

Comment 1 Arvid Requate

2016-01-04 13:25:38 CET

Patches backported.

Advisory: univention-samba4.yaml

Comment 2 Felix Botner

2016-01-11 16:03:02 CET

+ is_ucr_false samba4/sysvol/sync/from_downstream
/usr/share/univention-samba4/scripts/sysvol-sync.sh: line 232: is_ucr_false: command not found

Comment 3 Arvid Requate

2016-01-11 17:25:48 CET

Fixed, advisory updated.

Comment 4 Felix Botner

2016-01-11 17:50:05 CET

OK - sysvol-sync
OK - univention-samba4.yaml

Comment 5 Janek Walkenhorst

2016-01-12 12:31:32 CET

<http://errata.software-univention.de/ucs/4.0/381.html>