Bug 40782 - Allow users to send system setup errors as feedback to Univention
Allow users to send system setup errors as feedback to Univention
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Setup wizard
UCS 4.0
Other Linux
: P5 normal (vote)
: UCS 4.1-2-errata
Assigned To: Johannes Keiser
Florian Best
:
: 37087 (view as bug list)
Depends on:
Blocks: 40006
  Show dependency treegraph
 
Reported: 2016-02-26 11:40 CET by Alexander Kläser
Modified: 2016-10-04 10:45 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Error handling, Usability
Max CVSS v3 score:


Attachments
bug40782.patch (64.13 KB, patch)
2016-06-28 18:33 CEST, Johannes Keiser
Details | Diff
Screenshot (53.94 KB, image/png)
2016-07-15 15:22 CEST, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2016-02-26 11:40:06 CET
In order to better understand the kinds of errors users face when setting up UCS, it would be very helpful to allow sending the actual join/setup error they receive via our feedback channel. Optionally the chosen configuration settings could be sent, as well, along with an additional comment, maybe.
Comment 1 Florian Best univentionstaff 2016-06-07 18:40:03 CEST
*** Bug 37087 has been marked as a duplicate of this bug. ***
Comment 2 Johannes Keiser univentionstaff 2016-06-28 18:33:56 CEST
Created attachment 7772 [details]
bug40782.patch
Comment 3 Florian Best univentionstaff 2016-06-28 18:47:41 CEST
@Alex
We should not offer to send feedback via email, right? (In a virtual machine one cannot send a email).
→ If yes, Johannes, please remove getSendErrorsAsMailButton() from the patch (the whole logic can be simplified then)

2. Should we display the errors inline or as a pop up?
→ As a pop up would have the advantage that we could use umc.tools._fooTraceback() - which also handles appearance.

3. If not 2.
I think a field for a remark (editable) and a field with the traceback/errors (no editable) should be shown.
Comment 4 Florian Best univentionstaff 2016-06-28 18:47:53 CEST
The patch looks fine btw.
Comment 5 Johannes Keiser univentionstaff 2016-07-08 11:58:30 CEST
Occurred errors can now be send via sysinfo/traceback and if possible also per mail


r 70889
univention-system-setup (9.0.4-28) 
* Bug #40782: Allow users to send system setup errors as feedback


YAML: r 70890
Comment 6 Florian Best univentionstaff 2016-07-15 15:16:11 CEST
OK: Firefox
OK: Chromium
~OK: The error box doesn't disappear after sending feedback. There is a small pop up which says 'Thanks for your help'.
OK: from system-setup-browser
OK: "Send as email button" works
OK: "Send as email button" is only displayed when coming from external

REOPEN: There is no field where the user can write some remark
REOPEN: The entered email address is not set
REOPEN: if above is fixed, it must be clear that the email address is send along with the request
REOPEN: The feedback-email which we receive contains the traceback/error twice:
* 1. in the traceback field
* 2. in the remark field
Comment 7 Florian Best univentionstaff 2016-07-15 15:22:49 CEST
Created attachment 7807 [details]
Screenshot

(REOPEN): When sending the information to univention failed there is a nice pop up:
"""
Benachrichtigung
Das Versenden der Informationen zum Hersteller ist fehlgeschlagen. Sie können die Informationen auch per Mail schicken: Feedback als E-Mail senden
"""

The email button is also shown if we are in the system-setup-browser. Clicking on it causes firefox to pop up the window in the attached screenshot.
Comment 8 Florian Best univentionstaff 2016-07-15 15:25:40 CEST
There is a scrollbar shown in the system-setup-browser if the error is longer than 10 lines.
Comment 9 Johannes Keiser univentionstaff 2016-07-19 11:58:44 CEST
As discussed the errors are still displayed in-line but the feedback is handled
via tools._handleTraceback. If the setup is local the traceback function from sysinfo/lib is used directly since emails can not be send. Also fixed the scrollbar showing when there are to many error lines.

r 71084
univention-system-setup (9.0.4-32)

YAML: r 71085
Comment 10 Florian Best univentionstaff 2016-07-21 17:29:17 CEST
OK: HTML escaping
OK: latest changes
OK: scrollbar
OK: YAML

It would be nice if the email was prefilled but then we would need to touch the sysinfo module.
Comment 11 Janek Walkenhorst univentionstaff 2016-08-03 15:56:40 CEST
<http://errata.software-univention.de/ucs/4.1/234.html>