Bug 40808 – HTML tags in UMC module names are evaluated

Bug 40808 - HTML tags in UMC module names are evaluated


Summary:	HTML tags in UMC module names are evaluated

Status:	REOPENED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.x
Assigned To:	UMC maintainers
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-03-01 12:58 CET by Dirk Wiesenthal
Modified:	2019-03-10 16:08 CET (History)
CC List:	4 users (show)

See Also:	43755
What kind of report is it?:	Security Issue
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Security
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2016-03-01 12:58:15 CET

If an App's Name contains HTML, it is written in the apps.xml when installed.

This HTML is evaluated instead of escaped. This is a generic UMC problem.

ATTENTION: It may or may not be necessary to "unfix" certain modules that worked around this issue, namely UDM, maybe UVMM.

If this is not feasible, please re-tag to UMC - App Center. We could double escape apps.xml, although I think this is not the right place to fix it.

+++ This bug was initially created as a clone of Bug #35324 +++

Characters used in an app's name or version are correctly escaped by python.

Unfortunately, these are escaped again by the AppCenterGalleryPane. The put-selector escapes automatically with no option to disable it.

But we need the escaping both in frontend and backend for UCR variables, XML files, title attributes, etc. So this has to be fixed in AppCenterGalleryPane's renderRow.

Note that modules in "Installed Modules" are escaped correctly - the backend sends unescaped module definitions in modules/list

Comment 1 Stefan Gohmann

2019-01-03 07:21:10 CET

This issue has been filled against UCS 4.1. The maintenance with bug and security fixes for UCS 4.1 has ended on 5st of April 2018.

Customers still on UCS 4.1 are encouraged to update to UCS 4.3. Please contact
your partner or Univention for any questions.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or simply reopen the issue. In this case please provide detailed information on how this issue is affecting you.