Univention Bugzilla – Bug 41173
Folder name "Eigene Shares" not configurable
Last modified: 2016-11-10 16:00:46 CET
Multiple UCS@school customers (http://forum.univention.de/viewtopic.php?f=59&t=5724) requested a change of the folder name that holds links to the shares that belong to pupils and teachers. Currently, this string is hard coded to "Eigene Shares" (file ucs-school-user-logonscript.py).
We got this also twice reported via feedback@-mail.
"DC-Verwaltungsnetz" is also hardcoded.
"cn=klassen" for groups and shares is also hardcoded.
(In reply to Florian Best from comment #2) > "DC-Verwaltungsnetz" is also hardcoded. […] > "cn=klassen" for groups and shares is also hardcoded. Handled via bug 41231
Added UCRV ucsschool/userlogon/shares_foldername in r71356.
I am not satisfied with the UCR variable description: Description[de]=Name des Verzeichnisses das Links zu Laufwerken des Benutzers enthält (Standard: "Eigene Shares"). Wenn verändert, müssen alle logon Skripte neu geschrieben werden: "invoke-rc.d univention-directory-listener restart; univention-directory-listener-ctrl resync ucs-school-user-logonscript" Description[en]=Name of the directory containing links to the users shares (default: "Eigene Shares"). If changed, all logon scripts must be rewritten: "invoke-rc.d univention-directory-listener restart; univention-directory-listener-ctrl resync ucs-school-user-logonscript" I don't think a UCR variable should contain instructions how to restart and resync a listener module. Please remove that sentence completely. """Name des Verzeichnisses das Links zu Laufwerken des Benutzers enthält.""" At least a "," is missing. Maybe something like the following: "Name für das Verzeichnis auf dem Desktop, das Links zu Benutzerfreigaben enthält." @Sönke please have a look.
REOPEN: Since the variable is not hardcoded anymore it needs to be escaped: ucr set ucsschool/userlogon/shares_foldername='Meine "Shares' → This would break all scripts. What about the following scripts? They are using the old name: /var/lib/samba/sysvol/school.local/scripts/user/Administrator.vbs /var/lib/samba/sysvol/school.local/scripts/user/http-proxy-xen8.vbs /var/lib/samba/sysvol/school.local/scripts/user/join-backup.vbs /var/lib/samba/sysvol/school.local/scripts/user/join-slave.vbs
(In reply to Florian Best from comment #6) > I am not satisfied with the UCR variable description: > > Description[de]=Name des Verzeichnisses das Links zu Laufwerken des > Benutzers enthält (Standard: "Eigene Shares"). Wenn verändert, müssen alle > logon Skripte neu geschrieben werden: "invoke-rc.d > univention-directory-listener restart; univention-directory-listener-ctrl > resync ucs-school-user-logonscript" > Description[en]=Name of the directory containing links to the users shares > (default: "Eigene Shares"). If changed, all logon scripts must be rewritten: > "invoke-rc.d univention-directory-listener restart; > univention-directory-listener-ctrl resync ucs-school-user-logonscript" > > I don't think a UCR variable should contain instructions how to restart and > resync a listener module. Please remove that sentence completely. Ah yes - it should be only in the advisory. Done. > """Name des Verzeichnisses das Links zu Laufwerken des Benutzers enthält.""" > At least a "," is missing. > > Maybe something like the following: > "Name für das Verzeichnis auf dem Desktop, das Links zu Benutzerfreigaben > enthält." Done. (In reply to Florian Best from comment #7) > REOPEN: Since the variable is not hardcoded anymore it needs to be escaped: > ucr set ucsschool/userlogon/shares_foldername='Meine "Shares' > → This would break all scripts. Done (only double quotes must be escaped). > What about the following scripts? They are using the old name: > /var/lib/samba/sysvol/school.local/scripts/user/Administrator.vbs > /var/lib/samba/sysvol/school.local/scripts/user/http-proxy-xen8.vbs > /var/lib/samba/sysvol/school.local/scripts/user/join-backup.vbs > /var/lib/samba/sysvol/school.local/scripts/user/join-slave.vbs They can be regenerated by resyncing the listener module. r74013: UCRVs, escaping r74014: advisory: build#
r74032: All of the following characters are not supported in file/directory names, and are now stripped from the folder name: \/:*?"<>| r74033: advisory update
OK: name is changeable via UCR OK: UCRV description (de|en) OK: escaping works now OK: YAML (adjusted in r74034) ~ The script still fails if I e.g. set: ucr set ucsschool/userlogon/shares_foldername='"?:*'
UCS@school 4.1 R2 v7 has been released. http://docs.software-univention.de/changelog-ucsschool-4.1R2v7-de.html If this error occurs again, please clone this bug.