Bug 41222 - Translation tools ignore package saml/univention-saml
Translation tools ignore package saml/univention-saml
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-2-errata
Assigned To: Eduard Mai
Alexander Kläser
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-09 15:42 CEST by Alexander Kläser
Modified: 2016-09-21 20:38 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.011
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Internationalization
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2016-05-09 15:42:18 CEST
The translation tools ignore saml/univention-saml.

[Ticket#2016031421000382]
Comment 1 Florian Best univentionstaff 2016-05-10 07:48:24 CEST
I think an extra entry in specialcases.json will fix it.
Comment 2 Eduard Mai univentionstaff 2016-06-02 16:57:03 CEST
Rev. 69765: Adds saml/univention-saml to specialcases.json.
Package: univention-ucs-translation-template
Version: 3.0.1-7.10.201606021654
Branch: ucs_4.1-0
Scope: errata4.1-2
Comment 3 Alexander Kläser univentionstaff 2016-07-05 11:58:15 CEST
Could you remove the following entries from specialcases.json:

  umc/help/en.json
  *.html

This should be obsolete as we adapted the translation process to a purely PO-based approach.

The module is currently still not translated, see also Bug 41187. The reason for this is two-fold. Firstly, there is no debian/univention-saml.umc-modules file (i.e., the module description contained in the XML module file is not translated). Secondly, the de.po file is in the package root file and not below modules/univention/admin/handlers/saml. AFAIS, this needs to be changed via Bug 41187.
Comment 4 Alexander Kläser univentionstaff 2016-07-05 12:13:19 CEST
(In reply to Alexander Kläser from comment #3)
> [...]
> Secondly, the de.po file is in the package root file and not below
> modules/univention/admin/handlers/saml. AFAIS, this needs to be changed via
> Bug 41187.

This is wrong, the name of the MO file does not match:

> translation = univention.admin.localization.translation('univention.admin.handlers.saml-serviceprovider')

If the .umc-modules file is added via Bug 41187, everything should be fine then.
Comment 5 Eduard Mai univentionstaff 2016-07-15 16:13:42 CEST
(In reply to Alexander Kläser from comment #3)
> Could you remove the following entries from specialcases.json:
> 
>   umc/help/en.json
>   *.html

The obsolete special cases were removed via changes in Bug #41223 (r69767).
Comment 6 Alexander Kläser univentionstaff 2016-07-15 18:09:21 CEST
Changes: OK
YAML file: OK
Comment 7 Janek Walkenhorst univentionstaff 2016-08-03 15:56:50 CEST
<http://errata.software-univention.de/ucs/4.1/225.html>