Bug 41360 – Prepare App Center for Self Service (2)

Bug 41360 - Prepare App Center for Self Service (2)


Summary:	Prepare App Center for Self Service (2)

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P3 normal (vote)
Target Milestone:	UCS 4.1-2-errata
Assigned To:	Dirk Wiesenthal
QA Contact:	Florian Best

URL:
Keywords:

Depends on:
Blocks:	40996
	Show dependency tree / graph

Reported:	2016-05-26 15:17 CEST by Dirk Wiesenthal
Modified:	2016-10-11 12:48 CEST (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Wiesenthal

2016-05-26 15:17:20 CEST

As in Bug#40943, we need some more small changes for the Self Service module to work properly.

Some hacks were needed for the module, notably an error in appcenter.log's class UMCHandler.

Comment 1 Dirk Wiesenthal

2016-06-13 11:15:20 CEST

Did some code changes in r70010.

Comment 2 Dirk Wiesenthal

2016-06-13 11:18:37 CEST

Also r70011 for simplifying selfservice

Comment 3 Dirk Wiesenthal

2016-06-20 12:49:38 CEST

Also r70225, r70412, r70415.

Comment 4 Dirk Wiesenthal

2016-06-21 03:12:04 CEST

Removed dpkg-dev from the dependecy list in r70455

Comment 5 Florian Best

2016-06-21 11:22:06 CEST

REOPEN: as discussed, error handling around os.chmod(result_file, 0644).

The cache parameter is now configurable for univention-app update. But the app.py class always uses the hardcoded one. Is this okay? → you can't use e.g. AppManager instances in univention-app update then. This looks inconsistent IMHO.

IMHO appcenter.utils.mkdir should use os.makedirs().

Comment 6 Dirk Wiesenthal

2016-06-22 09:32:18 CEST

(In reply to Florian Best from comment #5)
> REOPEN: as discussed, error handling around os.chmod(result_file, 0644).
> 

univention-appcenter 5.0.21-12.175.201606211353

> The cache parameter is now configurable for univention-app update. But the
> app.py class always uses the hardcoded one. Is this okay? → you can't use
> e.g. AppManager instances in univention-app update then. This looks
> inconsistent IMHO.

Yes, this has been done for selfservice. It uses the all new (AppManager inspired) AppCache.

> 
> IMHO appcenter.utils.mkdir should use os.makedirs().

You are right. Not done in this bug.

Comment 7 Florian Best

2016-06-27 12:03:29 CEST

univention-appcenter (5.0.21-13):
r70476 | Bug #41360: Error handling for copy_file in univention-appcenter-dev
OK
r70455 | Bug #41360: Remove dpkg-dev dependency
~OK (The splitting works, I hope also in the future or in some special circumstances e.g. if whitespace in version, ...)
r70415 | Bug #41360: Add cache dir parameter to univention-app update.
OK
r70412 | Bug #41360: Add cache dir parameter to univention-app update.
OK
r70225 | Bug #41360: Fix typo
OK
r70010 | Bug #41360: Prepare App Center for Self Service
OK

Comment 8 Janek Walkenhorst

2016-06-29 12:26:38 CEST

<http://errata.software-univention.de/ucs/4.1/206.html>