Bug 41403 - Adjust query of TitlePanes in module code of updater
Adjust query of TitlePanes in module code of updater
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: UMC - Software update
UCS 4.1
Other Linux
: P5 enhancement (vote)
: ---
Assigned To: UMC maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-01 13:04 CEST by Alexander Kläser
Modified: 2019-01-03 07:19 CET (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:
best: Patch_Available+


Attachments
svn diff -c r69692 (3.27 KB, patch)
2016-09-20 12:01 CEST, Alexander Kläser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2016-06-01 13:04:37 CEST
The patch from Bug 41535 should be merged into the current version of the module. As soon as the order of the elements in the layout changes, this will break its logic.

univention-updater (10.0.57-3):
r69692 | Bug #41353: adjust query for titlepanes
Comment 1 Florian Best univentionstaff 2016-09-19 16:55:15 CEST
(In reply to Alexander Kläser from comment #0)
> The patch from Bug 41535 should be merged into the current version of the
> module. As soon as the order of the elements in the layout changes, this
> will break its logic.
> 
> univention-updater (10.0.57-3):
> r69692 | Bug #41353: adjust query for titlepanes

@Alex: hmm. I think you wrote a wrong bug number. Can you please have a look.
Comment 2 Alexander Kläser univentionstaff 2016-09-20 12:01:04 CEST
Created attachment 8021 [details]
svn diff -c r69692

(In reply to Florian Best from comment #1)
> @Alex: hmm. I think you wrote a wrong bug number. Can you please have a look.

Yes, that is a typo, the correct one is Bug 41353, as stated in the summary at the end:

(In reply to Alexander Kläser from comment #0)
> univention-updater (10.0.57-3):
> r69692 | Bug #41353: adjust query for titlepanes

DOM elements (here TitlePanes) are queried via fixed indices, e.g.:
> this._form._container.getChildren()[0]
And the commit r69692 changes that to make it more robust to change within the layout. I attached the patch of that revision.
Comment 3 Florian Best univentionstaff 2016-09-20 12:03:23 CEST
Ah yes, I remember, we should really merge this into UCS 4.x.
Comment 4 Stefan Gohmann univentionstaff 2019-01-03 07:19:18 CET
This issue has been filled against UCS 4.1. The maintenance with bug and security fixes for UCS 4.1 has ended on 5st of April 2018.

Customers still on UCS 4.1 are encouraged to update to UCS 4.3. Please contact
your partner or Univention for any questions.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or simply reopen the issue. In this case please provide detailed information on how this issue is affecting you.