Bug 41408 - 70_users_module: unexpected return values by UMC user wizard backend
70_users_module: unexpected return values by UMC user wizard backend
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Ucsschool-lib
UCS@school 4.1 R2
Other Linux
: P5 normal (vote)
: UCS@school 4.1 R2
Assigned To: Florian Best
Sönke Schwardt-Krummrich
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-01 15:56 CEST by Sönke Schwardt-Krummrich
Modified: 2016-09-30 12:26 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2016-06-01 15:56:21 CEST
http://jenkins.knut.univention.de:8080/job/UCSschool%204.1/job/UCSschool%204.1%20%28R2%29%20Singleserver/lastCompletedBuild/SambaVersion=s3/testReport/90_ucsschool/70_users_module/test/


essential.user.GetCheckFail: Failed get request for user e07epjcm8j. Returned result:
{u'$dn$': 'uid=e07epjcm8j,cn=schueler,cn=users,ou=iuaguly2husc,dc=autotest200,dc=local',
 'birthday': None,
 'disabled': 'none',
 'display_name': 'z54v02le8t uhlvg9azsd',
 'email': None,
 'firstname': 'z54v02le8t',
 'lastname': 'uhlvg9azsd',
 'name': 'e07epjcm8j',
 'objectType': 'users/user',
 'password': None,
 'record_uid': None,
 'school': 'iuaguly2husc',
 'school_class': 'aykhg8otbf',
 'schools': [u'iuaguly2husc'],
 'source_uid': None,
 'type': 'student',
 'type_name': 'Sch\xfcler',
 }
{'$dn$': 'uid=e07epjcm8j,cn=schueler,cn=users,ou=iuaguly2husc,dc=autotest200,dc=local',
 'birthday': None,
 'disabled': 'none',
 'display_name': 'z54v02le8t uhlvg9azsd',
 'email': None,
 'firstname': 'z54v02le8t',
 'lastname': 'uhlvg9azsd',
 'name': 'e07epjcm8j',
 'objectType': 'users/user',
 'password': None,
 'school': 'iuaguly2husc',
 'school_class': 'aykhg8otbf',
 'type': 'student',
 'type_name': 'Sch\xfcler',
}

The new properties "record_uid" and "source_uid" were not covered by the test script yet. 'school' now returns a list of OUs. Fixed these issues in 90_ucsschool/70_users_module.

Additionally "school_class" should return a dictionary school-->classes. This is currently not the case, but in accordance with Florian, the ucs-test script has already been altered accordingly:

 'school_class': {'iuaguly2husc': ['aykhg8otbf']},
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2016-06-01 16:09:24 CEST
ucs-test-ucsschool (3.0.5-33):
r69710 | Bug #41408: updated script 70_users_module due to changes for import tools and ou-overlapping users
Comment 2 Florian Best univentionstaff 2016-06-02 14:48:40 CEST
(In reply to Sönke Schwardt-Krummrich from comment #1)
> ucs-test-ucsschool (3.0.5-33):
> r69710 | Bug #41408: updated script 70_users_module due to changes for
> import tools and ou-overlapping users
This was not complete.

r69758 | Bug #41408: fixup svn r69710

I will see if the change is possible as we have a lot code using the current format:
 $ git grep school_class $(find -name '*.py') | wc -l
85
Comment 3 Florian Best univentionstaff 2016-06-07 17:47:33 CEST
Format and test adjusted:

ucs-test-ucsschool (3.0.6-6):
r69882 | Bug #41408: adjust tests for school_class → school_classes API change
r69805 | Bug #41408: source_id and record_id has been moved into ImportUser
r69759 | Bug #41408: fixup svn r69710
Comment 4 Florian Best univentionstaff 2016-06-13 13:26:27 CEST
interim version - no changelog.
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2016-06-15 23:11:45 CEST
OK: code change
OK: functional test
→ VERIFIED
Comment 6 Florian Best univentionstaff 2016-06-28 18:24:55 CEST
UCS@school 4.1 R2 has been released:
http://docs.software-univention.de/release-notes-ucsschool-4.1R2v1-de.pdf

If this error occurs again, please use "Clone This Bug".