Bug 41736 – UMC-client executes code

Bug 41736 - UMC-client executes code


Summary:	UMC-client executes code

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.1-2-errata
Assigned To:	Florian Best
QA Contact:	Dirk Wiesenthal

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-05 19:36 CEST by Florian Best
Modified:	2021-06-23 07:29 CEST (History)
CC List:	0 users

See Also:
What kind of report is it?:	Security Issue
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	5: Will affect all installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Security
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2016-07-05 19:36:32 CEST

umc-command -o "__import__('os').system('touch /tmp/hacked'):foo=bar" -n
umc-command -e -o "__import__('os').system('touch /tmp/hacked')" -n

As we use this script in various places with arguments from user input we should not allow code execution.

Comment 1 Florian Best

2016-07-12 13:40:29 CEST

Replace eval() by ast.literal_eval().

univention-management-console.yaml:
r70940 | YAML Bug #41736

univention-management-console (8.0.28-17):
r70939 | Bug #41736: don't execute/evaluate code in umc-client arguments

Comment 2 Dirk Wiesenthal

2016-07-18 14:24:18 CEST

There are little backward incompatibilities.

Anyway, the "features" dropped are not used and not useful.

Code: OK
YAML: OK

Comment 3 Janek Walkenhorst

2016-07-21 15:16:24 CEST

<http://errata.software-univention.de/ucs/4.1/212.html>