Univention Bugzilla – Bug 42172
The setup wizard should be a standalone application
Last modified: 2017-04-04 18:28:56 CEST
The current UCS setup wizard uses UMC as basis by appending the query string: ?username=__systemsetup__&password=${USSPASSWD}&module=setup&flavor=wizard&overview=false&lang=$default_locale This should be replaced by an own html site using the new UMC javascript library (→ Bug #38824).
I have moved the setup wizard into a standalone web application. univention-system-setup-boot should work as before. univention-system-setup (10.0.6-3): r76871 | Bug #42172: remove obsolete setup.css r76870 | Bug #42172: remove flavor wizard + remove references to ApplianceWizard r76867 | Bug #42172: move setup wizard into stand alone web application univention-management-console (9.0.34-1): r76867 | Bug #42172: move setup wizard into stand alone web application univention-web (1.0.26-2): r76873 | Bug #42172: revert last changes+fix inline label color in header search r76867 | Bug #42172: move setup wizard into stand alone web application changelog-4.2-0.xml: r76868 | Bug #42172: added changelog entry
As the flavor was removed the following UCR variables are unused, too: usr/sbin/univention-system-setup-boot:» » 'umc/module/setup/wizard/disabled' \ usr/sbin/univention-system-setup-boot:» » 'umc/module/setup/wizard/disabled=true' \ usr/share/univention-system-setup/startxwithfirefox:» /usr/sbin/univention-config-registry unset umc/module/setup/wizard/disabled The HTML files are part of the univention-system-setup-boot package? This package is removed in the cleanup-step, right? So if you finish the initial configuration the HTML files are removed. Might this lead to side effects (e.g. because of page reloads)?
dojo.js:13991 ReferenceError: _ is not defined(…) "ReferenceError: _ is not defined at Object.<anonymous> (http://xen3.school.local/univention/setup/main.js:187:20)
I addressed all comments via [r76932]: * Move setup wizard into univention-system-setup * Redirect access to /univention/management (for access != localhost) * Make sure that a reload on localhost is redirected to the last wizard page (if univention-system-setup-boot has been uninstalled) * Add missing reference to '_' * Remove referecnes to UCR variable umc/module/setup/wizard/disabled
univention-system-setup (10.0.7-2): r76933 | Bug #42172: adjust type in apache config
univention-system-setup (10.0.7-3): r76934 | Bug #42172: adjust another typo in apache config
/usr/sbin/univention-system-setup-boot: Zeile 72: is_ucr_true: Kommando nicht gefunden.
(In reply to Florian Best from comment #7) > /usr/sbin/univention-system-setup-boot: Zeile 72: is_ucr_true: Kommando > nicht gefunden. -> Bug #42133, but should be fixed here regardless
load-css.js:71 GET http://xen3.school.local/univention/management/modules/setup.css load-css.js:58 Error loading stylesheet /univention/management/modules/setup.css
(In reply to Florian Best from comment #7) > /usr/sbin/univention-system-setup-boot: Zeile 72: is_ucr_true: Kommando > nicht gefunden. Fixed. (In reply to Florian Best from comment #9) > load-css.js:71 GET > http://xen3.school.local/univention/management/modules/setup.css > load-css.js:58 Error loading stylesheet > /univention/management/modules/setup.css Fixed. We observed that umcp commands were sent before the authentication has been finished. I adjusted this, so the initialization of the wizard waits until the authentication has finished. univention-system-setup (10.0.7-6): r76989 | Bug #42172: remove css reference + add reference to ucr.sh r76987 | Bug #42172: wait with initialization until login has been completed
Created attachment 8452 [details] module-setup.log Reopen: with the current DVD build (ucs_4.2-0-20170223-060050-dvd-amd64.iso, univention-system-setup 10.0.7-7A~4.2.0.201702221613) a traceback appears when system setup is loaded: Die Ausführung des Kommandos setup/lang/locales wizard ist fehlgeschlagen: ... TypeError: cannot deepcopy this pattern object See attached log. When closing the traceback, the last wizard page is shown. When reloading the page, the traceback reappears.
The traceback is my bug, I will fix it.
I did an error when checking the UCR variable system/setup/boot/start which led to the wizard jumping every time to the last page. univention-system-setup (10.0.7-8): r77034 | Bug #42172: fix typo when checking the UCR variable system/setup/boot/start
The method _showDummyProgressbar() had not yet been moved into the wizard. This has been fixed. Module hook files are not loaded anymore. univention-system-setup (10.0.7-9): r77041 | Bug #42172: move _showDummyProgressbar() to wizard + adjust index.html
AFAIS, the language switch currently breaks with a JavaScript error. → REOPENED
Created attachment 8478 [details] installer: software selection On the software page * When selecting more than one item in the grid, one has to click exactly on the checkbox. Clicking on the title of another item, or even the 'info' icon, will deselect all other entries. Users will not expect this. And the the whole list is two pages long, so it will not be noticed immediately. * I think we should get rid of the scrollbar for the page (see screenshot). The 'next' button is not visible and clickable immediately, the whole page spans two pages. Maybe a scrollbar in the grid?
(In reply to Alexander Kläser from comment #15) > AFAIS, the language switch currently breaks with a JavaScript error. > > → REOPENED I fixed this problem, the logic was broken at some points. I also reorderd the www files... /var/www/univention/{setup,initialsetup} are now symlinks to /usr/share/univention-system-setup{/www,-boot/www}, respectively. This complies with all other packages which use symlinks in /var/www/univention, as well. univention-system-setup (10.0.7-16): r77204 | Bug #42172: Fix errors when changing the language + reorder files (In reply to Erik Damrose from comment #16) > Created attachment 8478 [details] > installer: software selection > > On the software page > * When selecting more than one item in the grid, one has to click exactly on > the checkbox. Clicking on the title of another item, or even the 'info' > icon, will deselect all other entries. Users will not expect this. And the > the whole list is two pages long, so it will not be noticed immediately. This is the same behaviour as with all other grids. > * I think we should get rid of the scrollbar for the page (see screenshot). > The 'next' button is not visible and clickable immediately, the whole page > spans two pages. Maybe a scrollbar in the grid? We consciously chose to make grids un-scrollable. Scrolling should be done via the page, instead. For both points I would like to wait for more feedback and leave it in the current state... for now. Both points need some discussion.
I moved some functionality which will be needed at other places into umc/tools. univention-system-setup (10.0.7-17): r77235 | Bug #42172: use umc/tools for isFQDN()/isIP*Address()
Created attachment 8484 [details] setup appliance with external browser: fixed width when accessing with an external browser (appliance mode), there seems to be a fixed witdh, except for the 'next' button
Created attachment 8485 [details] styling issues in applance mode In appliance mode, the following styling issues have been found: * Language selection: Text is ALL CAPS * City searchbox: example text is misaligned and only partly visible (only with internal browser, displayed correctly with external browser) * Unnecessary scrollbar (also other pages)
(In reply to Erik Damrose from comment #19) > Created attachment 8484 [details] > setup appliance with external browser: fixed width > > when accessing with an external browser (appliance mode), there seems to be > a fixed witdh, except for the 'next' button As discussed, I added a white card around the wizard for external browsers. (In reply to Erik Damrose from comment #20) > Created attachment 8485 [details] > styling issues in applance mode > > In appliance mode, the following styling issues have been found: > * Language selection: Text is ALL CAPS > * City searchbox: example text is misaligned and only partly visible (only > with internal browser, displayed correctly with external browser) > * Unnecessary scrollbar (also other pages) These issues have been fixed. I also optimized the standby animation to appear much smoother. univention-web (1.0.29-17): r77319 | Bug #43528: Add styling for cards + fix select box + buttons univention-system-setup (10.0.7-18): r77320 | Bug #42172: Adjust styling of wizard and elements
Clicks on the info icon will no longer alter the selection. I also added width=100% when the setup wizard is called within the VM console. univention-system-setup (10.0.7-19): r77324 | Bug #42172: Keep selection when clicking on info icon + optimize width
I updated the integration of the translations... r77335 | Bug #42172: Update l10n integration r77334 | Bug #42172: Update l10n integration
Should be OK for now, bug 43726 remains.
I needed to adjust the checks tools.isFQDN() + tools.isHostname(). univention-system-setup (10.0.7-22): r77472 | Bug #42172: Fix _validateHostname() check univention-web (1.0.31-13): r77471 | Bug #42172: adjust FQDN reg exp + add tools.isHostname() check
This is OK for now. For additional issues, new bugs will be created. -> Verified
UCS 4.2 has been released: https://docs.software-univention.de/release-notes-4.2-0-en.html https://docs.software-univention.de/release-notes-4.2-0-de.html If this error occurs again, please use "Clone This Bug".