Bug 42235 - Allow to customize background and logo of 4.2 portal
Allow to customize background and logo of 4.2 portal
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Portal
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Alexander Kläser
Stefan Gohmann
: interim-3
: 42236 (view as bug list)
Depends on:
Blocks: 42233 44096
  Show dependency treegraph
 
Reported: 2016-09-02 15:40 CEST by Alexander Kläser
Modified: 2017-04-04 18:28 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2016-09-02 15:40:59 CEST
Allow each user to customize the background of 4.2 portal
Comment 1 Alexander Kläser univentionstaff 2017-03-22 03:40:23 CET
*** Bug 42236 has been marked as a duplicate of this bug. ***
Comment 2 Alexander Kläser univentionstaff 2017-03-22 03:57:48 CET
Fixed. I needed to adapt the image widget in order to display also SVG graphics. Now any graphic types can be uploaded (jpg, png, svg) and will be rendered properly. I also increased the default upload maximum size to 2MB in order to allow larger background images for the portal. In addition to the background image, it is also possible to specify CSS background.

I just observe the following error when removing an image from a portal object and trying to save:

"Inappropriate matching: modify/delete: univentionPortalBackground: no
equality matching rule"

I do not know what exactly is causing this error... maybe the binary attribute type?


univention-ldap (13.0.5-6):
r78083 | Bug #42235: Add schema extensions for portal logo and CSS background

univention-directory-manager-modules (12.0.15-2):
r78084 | Bug #42235: Integrate portal logo and CSS background into UDM object

univention-management-console (9.0.68-2):
r78085 | Bug #42235: Increase the upload maximum default to 2MB

univention-web (1.0.39-23):
r78086 | Bug #42235 + Bug #44010

univention-management-console-module-udm (7.0.9-7):
r78087 | Bug #42235: Adjust styling of image upload widget for user picture

univention-portal (1.0.9-6):
r78088 | Bug #42235: Integrate custom background image and logo into portal

changelog-4.2-0.xml:
r78089 | Bug #42235: add changelog entry
Comment 3 Stefan Gohmann univentionstaff 2017-03-22 07:27:26 CET
(In reply to Alexander Kläser from comment #2)
> I just observe the following error when removing an image from a portal
> object and trying to save:
> 
> "Inappropriate matching: modify/delete: univentionPortalBackground: no
> equality matching rule"
> 
> I do not know what exactly is causing this error... maybe the binary
> attribute type?

I've created a new bug for it: Bug #44019
Comment 4 Stefan Gohmann univentionstaff 2017-03-22 07:44:58 CET
It looks really nice.

Currently, I don't see the logo I've uploaded, see for example:
 http://10.201.42.1/univention/portal/

The following logo is configured:
 http://10.201.42.1/univention/portal/icons/logos/domain.png

root@master421:~# rgrep domain.png /usr/share/univention-portal/
/usr/share/univention-portal/portal.json:    "logo": "/univention/portal/icons/logos/domain.png", 
root@master421:~#
Comment 5 Stefan Gohmann univentionstaff 2017-03-22 08:04:29 CET
Hm, it seems to be a caching issue. It makes the tests really hard. Maybe we could write random file names? For example domain-<random-numbers>.png
Comment 6 Alexander Kläser univentionstaff 2017-03-23 12:50:56 CET
(In reply to Stefan Gohmann from comment #5)
> Hm, it seems to be a caching issue. It makes the tests really hard. Maybe we
> could write random file names? For example domain-<random-numbers>.png

Fixed. Caching was indeed an issue. Images are not cached anymore.

univention-portal (1.0.10-5):
r78197 | Bug #42235: Make sure that portal background/logo images are not cached
Comment 7 Alexander Kläser univentionstaff 2017-03-23 16:37:30 CET
I forgot to include the portal.css file. Fixed & packages are building.

univention-portal (1.0.10-7):
r78219 | Bug #42235: Make sure the portal.css file is not cached
Comment 8 Stefan Gohmann univentionstaff 2017-03-23 18:40:20 CET
OK, it works as expected.
Comment 9 Florian Best univentionstaff 2017-03-27 19:32:09 CEST
/univention/portal/portal.css sometimes contains:
body.umc {
  background: url("None") no-repeat top center / cover;
}

Leading to a 404 HTTP Error:
/univention/portal/None 404 (Not Found)
Comment 10 Alexander Kläser univentionstaff 2017-03-27 20:00:22 CEST
(In reply to Florian Best from comment #9)
> /univention/portal/portal.css sometimes contains:
> body.umc {
>   background: url("None") no-repeat top center / cover;
> }
> 
> Leading to a 404 HTTP Error:
> /univention/portal/None 404 (Not Found)

A trailing "," changed None to (None, ) which, in turn, was always truthy.

univention-portal (1.0.10-12):
r78383 | Bug #42235: Remove trailing ',' and correct creation of portal.css
Comment 11 Stefan Gohmann univentionstaff 2017-03-27 20:54:26 CEST
OK, it works again.
Comment 12 Stefan Gohmann univentionstaff 2017-04-04 18:28:57 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".