Bug 42291 - Update JavaScript libs (Dojo 1.12.1, dgrid 1.1.0, xstyle 3.2.0)
Update JavaScript libs (Dojo 1.12.1, dgrid 1.1.0, xstyle 3.2.0)
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Jürn Brodersen
Florian Best
: interim-2
Depends on:
Blocks: 32027 49535
  Show dependency treegraph
 
Reported: 2016-09-06 16:00 CEST by Florian Best
Modified: 2019-05-23 17:56 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): API change
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2016-09-06 16:00:52 CEST
We should update Dojo to 1.11.2.

http://download.dojotoolkit.org/release-1.11.2/dojo-release-1.11.2-src.tar.gz
Comment 1 Alexander Kläser univentionstaff 2016-09-13 10:31:53 CEST
We also need updates for dgrid and xstyle AFAIS:
https://github.com/SitePen/dgrid/tree/v1.1.0
https://github.com/kriszyp/xstyle/tree/v0.3.2

We have the put-selector in its latest version, if I am correct.
Comment 2 Alexander Kläser univentionstaff 2016-09-13 11:22:31 CEST
We also need to include dstore for the dgrid:
https://github.com/SitePen/dstore
Comment 3 Jürn Brodersen univentionstaff 2016-10-20 09:33:30 CEST
First draft:
r73370: Update grid and tree widget for dgrid (univention-web)
r73371: Added/Updated dgrid and dstore (univention-dojo)

TODO:
* Cleanup grid widget (old xgrid code?)
* Check the less used features like disabling items
* Cleanup css styles (old styles for xgrid)
* More testing...
Comment 4 Florian Best univentionstaff 2016-10-20 13:13:26 CEST
You can remove the old dgrid-0.3.16.tar.gz from SVN.
Comment 5 Florian Best univentionstaff 2016-10-20 13:27:06 CEST
school/ucs-school-umc-csv-import/umc/js/schoolcsvimport.js
Needs to be updated accordingly. It defines gridOptions:

461 »   »   »   »   gridOptions: {
462 »   »   »   »   »   selectionMode: 'none',
463 »   »   »   »   »   canSort: function() {
464 »   »   »   »   »   »   return false;
465 »   »   »   »   »   },
466 »   »   »   »   »   plugins: {
467 »   »   »   »   »   »   menus: {
468 »   »   »   »   »   »   »   headerMenu: headerMenu
469 »   »   »   »   »   »   }
470 »   »   »   »   »   }
471 »   »   »   »   }
Comment 6 Florian Best univentionstaff 2016-10-20 15:55:05 CEST
(In reply to Jürn Brodersen from comment #3)
> * Check the less used features like disabling items
This can be tested with bridge/bonding/vlan configuration in the network settings.
Comment 7 Florian Best univentionstaff 2016-10-20 15:58:16 CEST
(In reply to Florian Best from comment #6)
> (In reply to Jürn Brodersen from comment #3)
> > * Check the less used features like disabling items
> This can be tested with bridge/bonding/vlan configuration in the network
> settings.
And also with the detailPage of a VM which is running in the UVMM module.
Comment 8 Jürn Brodersen univentionstaff 2017-01-31 11:50:12 CET
r76226: Updated dojo 1.12.1 and xstyle 0.3.2
Package: univention-dojo
Version: 10.0.0-3A~4.2.0.201701311135
Branch: ucs_4.2-0

r76228: ucslint.overrides update
Package: univention-web
Version: 1.0.8-2A~4.2.0.201701311142
Branch: ucs_4.2-0
Comment 9 Florian Best univentionstaff 2017-03-17 13:47:55 CET
REOPEN: Please add a changelog entry.
Comment 10 Florian Best univentionstaff 2017-03-17 14:14:28 CET
OK: dojo update to 1.12.1 → There is meanwhile 1.12.2 released.
OK: xstyle 3.2.0
OK: dgrid 1.1.0
OK: no put-selector update available
Comment 11 Jürn Brodersen univentionstaff 2017-03-17 14:20:50 CET
(In reply to Florian Best from comment #9)
> REOPEN: Please add a changelog entry.

r77889: Changelog for 4.2
Comment 12 Florian Best univentionstaff 2017-03-17 14:30:26 CET
r77891 | Changelog Bug #42291
OK: Changelog
Comment 13 Stefan Gohmann univentionstaff 2017-04-04 18:29:56 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".