Univention Bugzilla – Bug 42321
LinkList widget needs to be moved to u-m-c-module-udm package
Last modified: 2017-04-04 18:28:22 CEST
... LinkList calls umc/app.getModule(). This is UMC specific code for the UDM module. +++ This bug was initially created as a clone of Bug #38824 +++ We now have several packages that ship web code and show a UCS theme. It would be nice to bundle CSS and JavaScript code... probably into a separate package, although this would somewhat complicate the build process (i.e., it would mean building two packages to change a particular styling).
Fixed [r72437].
Still referenced here: management/univention-web/tests/form_widgets.html: "umc/widgets/LinkList", management/univention-web/tests/form_widgets.html: callback: function(win, Deferred, json, tools, Form, CheckBox, ComboBox, ComplexInput, DateBox, HiddenInput, Image, ImageUploader, LinkList, MixedInput, MultiInput, MultiObjectSelect, MultiSelect, Mult management/univention-web/tests/form_widgets.html: type: LinkList, management/univention-web/tests/form_widgets.html: label: 'LinkList', management/univention-web/tests/form_widgets.html: name: 'LinkList', IIRC IN8 also subclasses this: in8-udm/umc/js/udm/in8/externalAccountLink.js: "umc/widgets/LinkList" in8-udm/umc/js/udm/in8/externalAccountLink.js:], function(declare, lang, array, app, tools, LinkList) { in8-udm/umc/js/udm/in8/externalAccountLink.js: return declare('umc.modules.udm.in8.externalAccountLink', [LinkList], { And please remove the comment in the file: """ // FIXME: should be part of the UDM module """
(In reply to Florian Best from comment #2) > Still referenced here: > > management/univention-web/tests/form_widgets.html: > "umc/widgets/LinkList", > management/univention-web/tests/form_widgets.html: > callback: function(win, Deferred, json, tools, Form, CheckBox, ComboBox, > ComplexInput, DateBox, HiddenInput, Image, ImageUploader, LinkList, > MixedInput, MultiInput, MultiObjectSelect, MultiSelect, Mult > management/univention-web/tests/form_widgets.html: > type: LinkList, > management/univention-web/tests/form_widgets.html: > label: 'LinkList', > management/univention-web/tests/form_widgets.html: > name: 'LinkList', True, I removed the references. univention-web (1.0.6-1): r76208 | Bug #42321: Removed reference to LinkList in tests > IIRC IN8 also subclasses this: > in8-udm/umc/js/udm/in8/externalAccountLink.js: "umc/widgets/LinkList" > in8-udm/umc/js/udm/in8/externalAccountLink.js:], function(declare, lang, > array, app, tools, LinkList) { > in8-udm/umc/js/udm/in8/externalAccountLink.js: return > declare('umc.modules.udm.in8.externalAccountLink', [LinkList], { I sent Ingo an email to inform him. > And please remove the comment in the file: > """ > // FIXME: should be part of the UDM module > """ Done. univention-management-console-module-udm (7.0.3-5): r76209 | Bug #42321: removed 'FIXME' comment from LinkList
Looks good, but we should probably add a changelog for this bug?
(In reply to Florian Best from comment #4) > Looks good, but we should probably add a changelog for this bug? True! Fixed [r76220].
(In reply to Alexander Kläser from comment #5) > (In reply to Florian Best from comment #4) > > Looks good, but we should probably add a changelog for this bug? > > True! Fixed [r76220]. Okay, (this is in the section for UDM-CLI maybe "Development of modules for Univention Management Console" would have fit better).
UCS 4.2 has been released: https://docs.software-univention.de/release-notes-4.2-0-en.html https://docs.software-univention.de/release-notes-4.2-0-de.html If this error occurs again, please use "Clone This Bug".