Bug 42349 - Hide roles in wizards
Hide roles in wizards
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC
UCS@school 4.1 R2
Other Linux
: P5 normal (vote)
: UCS@school 4.1 R2 v10
Assigned To: Sönke Schwardt-Krummrich
Daniel Tröder
:
Depends on: 41387
Blocks: 43701
  Show dependency treegraph
 
Reported: 2016-09-12 09:44 CEST by Jan Christoph Ebersbach
Modified: 2017-03-21 12:35 CET (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Forked for project
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Christoph Ebersbach univentionstaff 2016-09-12 09:44:46 CEST
In UCS@school we have four roles: students, teachers, teachers and staff, staff.  They are visible in all wizards all the time although the specific environment might not use every role.  It should therefore be possible to hide unused roles because unused roles might confuse people.

See also Bug #41387.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2017-03-02 13:08:45 CET
It is now possible to specify a commaseparated list of UCS@school user roles to disable in UMC module "Users (schools)".

UCR variable: ucsschool/wizards/schoolwizards/users/roles/disabled
Possible values: student,teacher,staff,teachersAndStaff

Example: disable staff role by setting the following UCR variable:
ucr set \
   ucsschool/wizards/schoolwizards/users/roles/disabled=staff,teachersAndStaff

Package: ucs-school-umc-wizards
Version: 8.0.1-1.152.201703021300
Branch: ucs_4.1-0
Scope: ucs-school-4.1r2

ucs-school-umc-wizards.yaml:
r77238 | Bug #42349: hide disabled roles in search form of schoolwizards/users

ucs-school-umc-wizards (8.0.1-1):
r77238 | Bug #42349: hide disabled roles in search form of schoolwizards/users
Comment 2 Sönke Schwardt-Krummrich univentionstaff 2017-03-02 13:13:11 CET
The static value list in javascript has been replaced by a function in schoolwizards/utils.js that filters a static list and removes all values that are listed in the UCR variable mentioned above.
The UCR variable is only read once, so the UMC might have to be reloaded in browser to activate UCR variable changes.
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2017-03-02 15:37:19 CET
Sorting of the new filtered values has been disabled (→ same haviour as before).

ucs-school-umc-wizards.yaml:
r77257 | Bug #42349: updated advisory
r77254 | Bug #42349, 41387: updated advisory

ucs-school-umc-wizards (8.0.1-2):
r77253 | Bug #42349: updated copyright
r77248 | Bug #42349: fix regression of last commit: disable sorting of user roles

Package: ucs-school-umc-wizards
Version: 8.0.1-2.153.201703021519
Branch: ucs_4.1-0
Scope: ucs-school-4.1r2
Comment 4 Daniel Tröder univentionstaff 2017-03-03 11:44:17 CET
OK: advisory
OK: behavioral change is as desired: after setting the UCRV restarting UMCd and logging in again, no new users of the disabled types were found in the "add user" dialog. Existing users of the disabled types are still displayed.

As discussed, in this release the "manage workgroups" module has not been modified. It still displays disabled user types in its dialog window.
Comment 5 Daniel Tröder univentionstaff 2017-03-03 12:08:20 CET
Please remove "/wizards/" from ucsschool/wizards/schoolwizards/users/roles/disabled.
Other related UCRV names start with ucsschool/<module>/ like ucsschool/csvimport, ucsschool/workgroup, ucsschool/passwordreset.
Comment 6 Daniel Tröder univentionstaff 2017-03-03 14:31:27 CET
OK - I see now, that while the ^ucsschool/ namespace is used inconsistently directly below it, in the next level (modules) it is consistent. There are multiple UCRVs below ucsschool/wizards/schoolwizards/.
Comment 7 Daniel Tröder univentionstaff 2017-03-03 14:31:39 CET
All fine then.
Comment 8 Sönke Schwardt-Krummrich univentionstaff 2017-03-21 12:35:54 CET
UCS@school 4.1 R2 v10 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.1R2v10-de.html

If this error occurs again, please clone this bug.