Bug 42665 - univention-directory-logger issues
univention-directory-logger issues
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: LDAP
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.1-3-errata
Assigned To: Philipp Hahn
Felix Botner
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-13 10:57 CEST by Philipp Hahn
Modified: 2016-10-26 17:09 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.006
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:
hahn: Patch_Available+


Attachments
42665.diff (5.36 KB, patch)
2016-10-17 14:40 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2016-10-13 10:57:46 CEST
1. UCRV ldap/logging/dellogdir is not described
2. UCRV ldap/logging should use type=bool
3. createFile(..., withdirs=False) is unused
4. createFile() declares ro-variables as global
Comment 1 Philipp Hahn univentionstaff 2016-10-13 11:44:25 CEST
r73125 | Bug #42665 log: Removed global declarations
r73124 | Bug #42665 log: Remove unused argument
r73123 | Bug #42665 log: Skip on first hit
r73122 | Bug #42665 log: Open file using context
r73121 | Bug #42665 log: Parse dellog as boolean
r73120 | Bug #42665 log: Document UCRV dellog

Package: univention-directory-logger
Version: 7.0.1-2.39.201610131121
Branch: ucs_4.1-0
Scope: errata4.1-3

r73139 | Bug #42665 log: Removed global declarations
r73138 | Bug #42665 log: Remove unused argument
r73137 | Bug #42665 log: Skip on first hit
r73136 | Bug #42665 log: Open file using context
r73135 | Bug #42665 log: Parse dellog as boolean
r73134 | Bug #42665 log: Document UCRV dellog

r73141 | Bug #25404,Bug #34916,Bug #34420,Bug #42665: univention-directory-logger YAML
 univention-directory-logger.yaml
Comment 2 Philipp Hahn univentionstaff 2016-10-17 14:40:31 CEST
Created attachment 8119 [details]
42665.diff

c5aee01 Bug #42665 log: Removed global declarations
c409e0f Bug #42665 log: Remove unused argument
cc7787c Bug #42665 log: Skip on first hit
54e8ac2 Bug #42665 log: Open file using context
1edd4e3 Bug #42665 log: Parse dellog as boolean
9c3309e Bug #42665 log: Document UCRV dellog
13402fb Bug #34916 log: Stop cloning old and new

without

a259715 Bug #34916 log: Rename debian/ files
 rm debian/dirs # not needed
 mv debian/postinst debian/univention-directory-logger.postinst
 mv debian/postrm   debian/univention-directory-logger.postrm
992b173 Bug #34916 log: autopep8
 Run <https://hutten.knut.univention.de/mediawiki/index.php/Code-Richtlinien#Automatisiere_Tools>
ae93090 Bug #25404 log: Copyright 2016
 run uniupdatecopyright instead
Comment 3 Felix Botner univentionstaff 2016-10-21 16:07:45 CEST
OK - Removed global declarations
OK - Remove unused argument
OK - Skip on first hit
OK - Open file using context
OK - Parse dellog as boolean
OK - Document UCRV dellog

OK - YAML
OK - merged to 4.2 (4.1-4)
Comment 4 Philipp Hahn univentionstaff 2016-10-21 16:08:34 CEST
r73456 | Bug #42665 log: Workaroung ucr.iteritems() Bug #33101 YAML
r73455 | Bug #42665 log: Workaroung ucr.iteritems() Bug #33101
r73454 | Bug #42665 log: Workaroung ucr.iteritems() Bug #33101
r73453 | Bug #42665 log: Workaroung ucr.iteritems() Bug #33101

Package: univention-directory-logger
Version: 7.0.1-4.41.201610211546
Branch: ucs_4.1-0
Scope: errata4.1-3
Comment 5 Janek Walkenhorst univentionstaff 2016-10-26 17:09:04 CEST
<http://errata.software-univention.de/ucs/4.1/317.html>