Bug 42716 – Invalid code in S4-Connector dns_dn_mapping for _msdcs

Bug 42716 - Invalid code in S4-Connector dns_dn_mapping for _msdcs


Summary:	Invalid code in S4-Connector dns_dn_mapping for _msdcs

Status:	RESOLVED DUPLICATE of bug 32086

Product:	UCS
Classification:	Unclassified
Component:	S4 Connector
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Connector maintainers
QA Contact:

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-10-18 18:01 CEST by Arvid Requate
Modified:	2016-11-30 15:45 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Cleanup
Max CVSS v3 score:

Flags:	requate: Patch_Available+

Attachments
msdcs_soadn_fix.diff (697 bytes, patch) 2016-10-18 18:01 CEST, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2016-10-18 18:01:35 CEST

Created attachment 8130 [details]
msdcs_soadn_fix.diff

As Lukas discovered today there is an invalid code line in the dns_dn_mapping function of the S4-Connector:

  _rdn = [s4_RR_attr.upper() + '=' + target_zone_dn] + rdn[2:]
  target_zone_dn = ','.join(_rdn)

This looks like a typo, I guess this should be:

  _rdn = [s4_RR_attr.upper() + '=' + target_zone_name] + rdn[2:]


No clue if this has any impact currently, but it would be good to fix this,
see attached patch.

Comment 1 Florian Best

2016-10-18 18:48:35 CEST

The function also does no LDAP DN escaping.

Comment 2 Florian Best

2016-11-30 15:45:16 CET

This is probably one reason why we catched and ignored ldap.INVALID_DN_SYNTAX.

Comment 3 Florian Best

2016-11-30 15:45:51 CET


*** This bug has been marked as a duplicate of bug 32086 ***