Bug 42809 - univention-samba: cleanup share_restrictions.py
univention-samba: cleanup share_restrictions.py
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: Samba
UCS 4.2
Other Linux
: P5 normal (vote)
: ---
Assigned To: Samba maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-01 09:20 CET by Daniel Tröder
Modified: 2020-07-03 20:51 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:
best: Patch_Available+


Attachments
code cleanup (1.54 KB, patch)
2016-11-01 09:20 CET, Daniel Tröder
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2016-11-01 09:20:07 CET
Created attachment 8175 [details]
code cleanup

+++ This bug was initially created as a clone of Bug #26899 +++
+++ This bug was initially created as a clone of Bug #26865 +++

Various problems were found in ucs-4.1-3/services/univention-samba/python/share_restrictions.py while working on Bug #41231.

Attached is a possible code cleanup. It only makes the code valid - no idea if it is also meaningful, as I don't know about its intentions!

It however clear, that without the fixes some of the following UCRVs are not interpreted correctly (or at all) by the corresponding UCR-module:

Script: samba.local.config.py
Variables: samba/share/.*/usergroup/.*/invalid
Variables: samba/share/.*/hosts/deny
Variables: samba/share/.*/options
Variables: samba/global/options
Variables: samba/printmode/usergroup
Variables: samba/printmode/hosts/.*
Variables: samba/othershares/usergroup/.*/invalid
Variables: samba/othershares/hosts
Comment 1 Florian Best univentionstaff 2016-11-01 09:52:17 CET
The patch against UCS/univention-samba uses UCR variables from UCS@school. If we need to patch univention-samba to fix Bug #41231 then the UCR variable should be registered in univention-samba.
Comment 2 Ingo Steuwer univentionstaff 2020-07-03 20:51:41 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.