Bug 43073 - samba.conf uses python-netifaces - breaks with PXE installation badly
samba.conf uses python-netifaces - breaks with PXE installation badly
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba4
UCS 4.1
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Arvid Requate
Stefan Gohmann
: interim-2
: 41056 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-29 13:35 CET by Philipp Hahn
Modified: 2017-04-04 18:28 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.046
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2015072221000236
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2016-11-29 13:35:31 CET
services/univention-samba/conffiles/etc/samba/smb.conf.d/01univention-samba_main uses python-netifaces to get the list of network interfaces; they are used to generate the "interfaces" statements specifying the interfaces samba should listen on.
In some scenarios (PXE installation, interfaces/restart/auto=no) the runtime configuration differs from the configured configuration: During installation the bridge "br0" is not yet available and thus does NOT get added to "interfaces". After the reboot /etc/samba/smb.conf is not committed again and thus only "lo" remains as the only usable interface. This breaks Kerberos authentication, login as Administrator, joining Windows clients, etc...

Task #4777 2016-11-24/25 - UCS-Technikschulung - Bremen
Comment 1 Arvid Requate univentionstaff 2016-11-29 19:47:03 CET
IIRC I've also seen "eth0 eth1 eth2 eth3 eth4 eth5" [...] listed, even though only eth0 was configured.
Comment 2 Philipp Hahn univentionstaff 2016-11-30 08:19:52 CET
(In reply to Arvid Requate from comment #1)
> IIRC I've also seen "eth0 eth1 eth2 eth3 eth4 eth5" [...] listed, even
> though only eth0 was configured.

It also picks up the tap interfaces of all VMs running at the time smb.conf is committed.
But samba seems to use only those interfaces with an IP configuration, thus ventX and ethY are ignored as they are IP-less members of a brZ.
Nevertheless I would appreciate it if Samba would use the configured interfaces as every other service in UCS does.
Comment 3 Philipp Hahn univentionstaff 2017-01-04 09:36:49 CET
*** Bug 41056 has been marked as a duplicate of this bug. ***
Comment 4 Arvid Requate univentionstaff 2017-02-16 15:24:12 CET
Fixed in univention-samba and univention-samba4.
Changelog updated.
Comment 5 Stefan Gohmann univentionstaff 2017-02-24 07:24:38 CET
Tests: OK, it doesn't break anything even if the configured interface doesn't exist. The docker interface is still by default excluded. If one excluded lo, it won't work any longer, but I think in this case samba/interfaces can be used.

Code review: OK (r76761 + r76758)

Changelog: OK
Comment 6 Stefan Gohmann univentionstaff 2017-04-04 18:28:47 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".