Univention Bugzilla – Bug 43397
filter generation broken in 'connector/s4/mapping/dc/ignorelist'
Last modified: 2019-10-15 16:59:38 CEST
Created attachment 8369 [details] patch With the UCR variable connector/s4/mapping/dc/ignorelist: ucs01 a reject happens: 23.01.2017 13:09:31,333 LDAP (PROCESS): sync from ucs: Resync rejected file: /var/lib/univention-connector/s4/1484658595.135622 23.01.2017 13:09:31,349 LDAP (WARNING): sync failed, saved as rejected /var/lib/univention-connector/s4/1484658595.135622 23.01.2017 13:09:31,349 LDAP (WARNING): Traceback (most recent call last): File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 987, in resync_rejected_ucs if self.__sync_file_from_ucs(filename, append_error=' rejected'): File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 837, in __sync_file_from_ucs if not self._ignore_object(key, object) or ignore_subtree_match: File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1705, in _ignore_object if self.property[key].ignore_filter and self._filter_match(self.property[key].ignore_filter, object['attributes']): File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1688, in _filter_match return subfilter(filter, attributes) File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1680, in subfilter return subfilter(filter[1:-1], attributes) File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1683, in subfilter return connecting_filter(filter, attributes) File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1670, in connecting_filter return 1 in walk(filter[1:], attributes) File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1662, in walk results.append(subfilter(filter, attributes)) File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1686, in subfilter return attribute_filter(filter, attributes) File "/usr/lib/pymodules/python2.7/univention/s4connector/__init__.py", line 1594, in attribute_filter raise ValueError('missing "=" in filter: %s' % filter) ValueError: missing "=" in filter: ucs01 More debug information are at the ticket. Attached is a fix which needs to be applied against /etc/univention/connector/s4/mapping.
@Jens: Please set the customer ID.
curl https://forge.univention.org/bugzilla/attachment.cgi?id=8369 | sed 's/mapping.py/mapping/g' | patch -p8 -d /etc/univention/connector/s4/
Does it work if you set connector/s4/mapping/dc/ignorelist to cn=ucs01?
(In reply to Stefan Gohmann from comment #3) > Does it work if you set connector/s4/mapping/dc/ignorelist to cn=ucs01? Well, but there is another check which will fail then: conffiles/etc/univention/s4connector/s4/mapping.py-434-ignore_filter = '' conffiles/etc/univention/s4connector/s4/mapping.py:435:for dc in configRegistry.get('connector/s4/mapping/dc/ignorelist', '').split(','): conffiles/etc/univention/s4connector/s4/mapping.py-436-» if dc: conffiles/etc/univention/s4connector/s4/mapping.py-437-» » ignore_filter += '(cn=%s)' % (dc)
*** Bug 43407 has been marked as a duplicate of this bug. ***
Also consider Bug #43407 attachment 8371 [details]
Created attachment 8400 [details] Fix to the mapping.py and correction in postinst-script The attached patches fix the errors in `mapping.py` and the postinst-script. They also add a case in the postinst-script to correct already misconfigured systems.
Commited in r76451 + r76452.
# ucr unset connector/s4/mapping/dns/ignorelist Unsetting connector/s4/mapping/dns/ignorelist # invoke-rc.d univention-s4-connector restart Stopping Univention S4 Connector: univention-s4-connector. Starting Univention S4 Connector: univention-s4-connector^[[A^[[A^[[ATraceback (most recent call last): File "/usr/lib/pymodules/python2.7/univention/s4connector/s4/main.py", line 64, in <module> import mapping File "/etc/univention/connector/s4/mapping.py", line 530 'msGPO': univention.s4connector.property ( ^ SyntaxError: invalid syntax failed! invoke-rc.d: initscript univention-s4-connector, action "restart" failed.
Fixed in r76498.
OK: filter expressions are correctly build OK: postinst update code OK: changelog
UCS 4.2 has been released: https://docs.software-univention.de/release-notes-4.2-0-en.html https://docs.software-univention.de/release-notes-4.2-0-de.html If this error occurs again, please use "Clone This Bug".