Univention Bugzilla – Bug 43403
The system diagnostic tool should only make a ssh check on a already joined server
Last modified: 2018-05-16 17:03:54 CEST
In a school environment the customer adds the school slaves in the umc and joins them later. The slave object now exists in LDAP and is checked by the system diagnostics modul. This shows obviously an error message for the ssh check, because the server is not reachable. We could query the nagios support flag. I think this is set if the slave is joined?
We could simply select only servers with univentionService=*. The services only get added by the joinscripts AFAIK.
I'm raising the user pain after feedback from a customer. We do have more and more customers that use UCS@school without schoolservers at all (see http://docs.software-univention.de/ucsschool-szenarien-4.3-de.html#scenario-1). However, adding a new school requires to specify a school server (Bug #46724). And if you use "create_ou" on the commandline, it will create one for you, even if you don't specify one. This way we end up with a lot of dummy computer objects that will never be joined, but the system diagnostics' SSH check desperately tries to connect to. I am currently using this ldapsearch filter to find those unjoined servers: > '(&(univentionObjectType=computers/domaincontroller_slave)(!(krb5Key=*)))'
Successful build Package: univention-management-console-module-diagnostic Version: 4.0.0-27A~4.3.0.201804191303 Branch: ucs_4.3-0 Scope: errata4.3-0 univention-management-console-module-diagnostic (4.0.0-27) 62159882cb39 | Bug #43403: disable ssh diagnostic for computer objects without ip I simply disabled the test for all computer objects that don't have an ip address attached to them.
ucslint says: C: 42, 0: Wrong continued indentation (add 6 spaces). 'computers/domaincontroller_master', ^ | (bad-continuation) C: 43, 0: Wrong continued indentation (add 6 spaces). 'computers/domaincontroller_slave', ^ | (bad-continuation) C: 44, 0: Wrong continued indentation (add 6 spaces). 'computers/memberserver'] ^ | (bad-continuation) And we need an advisory for the package in doc/errata/staging/
sorry I mean pylint
univention-management-console-module-diagnostic (4.0.0-28) fb01ff11de11 | Bug #43403: adjust indentation
--- mirror/ftp/4.3/unmaintained/component/4.3-0-errata/source/univention-management-console-module-diagnostic_4.0.0-26A~4.3.0.201803231038.dsc +++ apt/ucs_4.3-0-errata4.3-0/source/univention-management-console-module-diagnostic_4.0.0-28A~4.3.0.201804301034.dsc @@ -1,6 +1,14 @@ -4.0.0-26A~4.3.0.201803231038 [Fri, 23 Mar 2018 10:38:00 +0100] Univention builddaemon <buildd@univention.de>: +4.0.0-28A~4.3.0.201804301034 [Mon, 30 Apr 2018 10:34:29 +0200] Univention builddaemon <buildd@univention.de>: * UCS auto build. No patches were applied to the original source package + +4.0.0-28 [Mon, 30 Apr 2018 10:27:42 +0200] Jannik Ahlers <ahlers@univention.de>: + + * Bug #43403: adjust indentation + +4.0.0-27 [Thu, 19 Apr 2018 12:50:44 +0200] Jannik Ahlers <ahlers@univention.de>: + + * Bug #43403: disable ssh test for computer objects without ip 4.0.0-26 [Tue, 20 Mar 2018 11:30:58 +0100] Jannik Ahlers <ahlers@univention.de>:
Verified: * Code review: Ok * Functional test: Ok * Advisory: Ok
<http://errata.software-univention.de/ucs/4.3/39.html>