Bug 43430 – wrong DN syntax handling

Bug 43430 - wrong DN syntax handling


Summary:	wrong DN syntax handling

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Printserver
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-0-errata
Assigned To:	Florian Best
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:	43332
Blocks:
	Show dependency tree / graph

Reported:	2017-01-27 09:30 CET by Philipp Hahn
Modified:	2019-03-20 12:29 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Security
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philipp Hahn

2017-01-27 09:30:12 CET

+++ This bug was initially created as a clone of Bug #43332 +++
$ git grep -n "[Dd][Nn].*\.find([\"'],[\"'])"
services/univention-printserver/cups-printers.py:273:                                   argument += '%s,' % userDn[userDn.find('=') + 1:userDn.find(',')]
services/univention-printserver/cups-printers.py:275:                                   argument += '@%s,' % groupDn[groupDn.find('=') + 1:groupDn.find(',')]
services/univention-printserver/cups-printers.py:373:                           user = dn[dn.find('=') + 1:dn.find(',')]
services/univention-printserver/cups-printers.py:379:                           group = "@" + dn[dn.find('=') + 1:dn.find(',')]

Use .parentDn() or ldap.dn.dn2str(ldap.dn.str2dn(...)...)

Comment 1 Florian Best

2019-03-14 17:03:09 CET

ldap.dn.explode_dn() is now used.

univention-printserver (12.0.1-3)
3844b5fb3f7d | Bug #43430: correctly split DN components

univention-printserver.yaml
cb85228146e9 | YAML Bug #43430
3844b5fb3f7d | Bug #43430: correctly split DN components

Comment 2 Jürn Brodersen

2019-03-14 17:18:38 CET

What I tested:
Added a printer and allowed only selected users/groups -> cups config is updated -> OK

YAML -> OK

Comment 3 Arvid Requate

2019-03-20 12:29:24 CET

<http://errata.software-univention.de/ucs/4.4/9.html>