Bug 43507 - Partitions with deactivated quota have no default action
Partitions with deactivated quota have no default action
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Quota
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Jürn Brodersen
Florian Best
: interim-4
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-07 11:22 CET by Jürn Brodersen
Modified: 2017-04-04 18:29 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.057
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
proposed patch (588 bytes, patch)
2017-02-07 12:12 CET, Jürn Brodersen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2017-02-07 11:22:08 CET
I think we should set "activate quota" as the default action for partitions with deactivated quota.
Currently no action is set.
Comment 1 Florian Best univentionstaff 2017-02-07 11:30:33 CET
Hm, I thought currently the default action is to open the partition (at least if it is enabled).
Comment 2 Jürn Brodersen univentionstaff 2017-02-07 11:46:24 CET
(In reply to Florian Best from comment #1)
> Hm, I thought currently the default action is to open the partition (at
> least if it is enabled).

Yes if quota is enabled for that partition. If no default action is send by the backend, "edit" is chosen as a fallback.

But partitions with deactivated quota have no "edit" action. Resulting in no default action.
Comment 3 Florian Best univentionstaff 2017-02-07 11:53:58 CET
(In reply to Jürn Brodersen from comment #2)
> (In reply to Florian Best from comment #1)
> > Hm, I thought currently the default action is to open the partition (at
> > least if it is enabled).
> 
> Yes if quota is enabled for that partition. If no default action is send by
> the backend, "edit" is chosen as a fallback.
> 
> But partitions with deactivated quota have no "edit" action. Resulting in no
> default action.

The backend doesn't set the 'edit' action. This is defined in umc.widgets.Grid.defaultAction which is set to 'edit'. You currently can't specify two default actions.
Comment 4 Jürn Brodersen univentionstaff 2017-02-07 12:12:32 CET
Created attachment 8408 [details]
proposed patch

ok, the patch would add a defaultAction function to the quota module.
Comment 5 Jürn Brodersen univentionstaff 2017-03-23 10:23:11 CET
r78181: fix default action for partitions with active quota
Package: univention-quota
Version: 11.0.0-5
Comment 6 Florian Best univentionstaff 2017-03-23 14:28:35 CET
OK: default action is set
OK: Changelog
Comment 7 Stefan Gohmann univentionstaff 2017-04-04 18:29:52 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".