Bug 43598 - Write test cases for LDAP Filter / DN escaping
Write test cases for LDAP Filter / DN escaping
Status: CLOSED FIXED
Product: UCS Test
Classification: Unclassified
Component: S4 Connector
unspecified
Other Linux
: P5 normal (vote)
: ---
Assigned To: Lukas Oyen
Florian Best
:
Depends on: 44374
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-21 13:42 CET by Florian Best
Modified: 2017-06-23 18:39 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
oyen: Patch_Available+


Attachments
test case (2.62 KB, text/plain)
2017-02-21 13:46 CET, Florian Best
Details
Patch-series with preparations and two new tests cases (60.00 KB, application/x-tar)
2017-04-13 16:18 CEST, Lukas Oyen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2017-02-21 13:42:10 CET
We need test cases for LDAP Filter / DN escaping in the S4-Connector.

+++ This bug was initially created as a clone of Bug #32086 +++
Comment 1 Florian Best univentionstaff 2017-02-21 13:46:52 CET
Created attachment 8444 [details]
test case

It makes sense to migrate the test cases to python to parametrize them. There are already cloned test case which do the same things with different names (special_chars). Attached is a python version which could be used as base.
Comment 2 Lukas Oyen univentionstaff 2017-04-13 16:18:08 CEST
Created attachment 8778 [details]
Patch-series with preparations and two new tests cases

The attached patch-series implements two new S4C tests cases with complex users/groups to test the LDAP escaping within the S4C.

They are attached because 1) it depends on bug #44373 and 2) some discussion may be necessary if this is sufficient.
Comment 3 Lukas Oyen univentionstaff 2017-05-08 15:46:18 CEST
Committed in r79190 - r79206. r79205 disables the cases where the s4connector yields a traceback and the new tests fail. This should be reverted after bug #44374 is fixed.
Comment 4 Florian Best univentionstaff 2017-05-09 15:21:44 CEST
very nice! both tests are working and all other tests still work.