Bug 43604 - Integrate login, portal etc. into piwik
Integrate login, portal etc. into piwik
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Alexander Kläser
Jürn Brodersen
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-22 09:42 CET by Alexander Kläser
Modified: 2017-04-04 18:29 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2017-02-22 09:42:44 CET
We need to update the piwik integration w.r.t. to the new components such as login, portal, self service etc.
Comment 1 Alexander Kläser univentionstaff 2017-03-18 23:55:22 CET
Fixed. IMHO, we do not need a changelog entry.

I moved various information into meta.json in order to make them available globally to any web interface. Among this data, there should not be any sensitive data (e.g., UUIDs etc.). Some license evaluation which used to be done in the JavaScript code is now also being done in the logic of the UCR template file. In consequence, the JavaScript code could be simplified (in UMC + the setup wizard).

The login/logout/relogin events needed some adjustments. They are now sent correctly, e.g., also when a relogin in triggered in a different tab. a page-loaded event is sent after a web site has been loaded. The URL contains now the URI path in order to allow to distinguish between UMC, portal etc. Piwik events have been added to all menu entries. ATM, I did not see any other events of interest in the portal, server overview, self service...


univention-web (1.0.39-7):
r77939 | Bug #43604: Move more data into meta.json + improve piwik integration

univention-management-console (9.0.65-2):
r77940 | Bug #43604: Adjust piwik integration + remove obsolete UCR requests

univention-system-setup (10.0.9-9):
r77941 | Bug #43604: Adjust piwik integration

univention-self-service (2.0.10-3):
r77942 | Bug #43604: Adjust piwik integration

univention-management-console-module-udm (7.0.8-2):
r77943 | Bug #43604: Adjust piwik integration

univention-management-console-module-reboot (6.0.0-4):
r77944 | Bug #43604: Adjust piwik integration

univention-management-console-module-passwordchange (2.0.2-9):
r77945 | Bug #43604: Adjust piwik integration
Comment 2 Alexander Kläser univentionstaff 2017-03-20 13:01:46 CET
I adjusted a few typos.

univention-web (1.0.39-10):
r77969 | Bug #43604: Fix JS typos
Comment 3 Alexander Kläser univentionstaff 2017-03-27 09:39:42 CEST
See Bug 43977, various meta information have been moved away from meta.json. This should only have the following effect for piwik: ucsVersion + uuid is only sent if user is logged in. However, as these are session variables, this info should be available in piwik even if a user has logged in after some other actions.
Comment 4 Jürn Brodersen univentionstaff 2017-03-28 10:36:09 CEST
univention/setup/ never requires "umc/piwik" -> piwik is not loaded for the setup
Comment 5 Alexander Kläser univentionstaff 2017-03-28 11:16:28 CEST
(In reply to Jürn Brodersen from comment #4)
> univention/setup/ never requires "umc/piwik" -> piwik is not loaded for the
> setup

True. I added the dependency.

univention-system-setup (10.0.10-8):
r78391 | Bug #43604: Make sure that piwik is required
Comment 6 Jürn Brodersen univentionstaff 2017-03-28 13:07:38 CEST
(In reply to Alexander Kläser from comment #5)
> (In reply to Jürn Brodersen from comment #4)
> > univention/setup/ never requires "umc/piwik" -> piwik is not loaded for the
> > setup
> 
> True. I added the dependency.
> 
> univention-system-setup (10.0.10-8):
> r78391 | Bug #43604: Make sure that piwik is required

Piwik is now loaded before the metadata containing piwikDisabled is mixed in.
Comment 7 Alexander Kläser univentionstaff 2017-03-28 13:12:40 CEST
(In reply to Jürn Brodersen from comment #6)
> Piwik is now loaded before the metadata containing piwikDisabled is mixed in.

Fixed.

univention-system-setup (10.0.10-11):
r78406 | Bug #43604: Trigger piwik load after meta data has been fetched
Comment 8 Jürn Brodersen univentionstaff 2017-03-28 18:32:36 CEST
What I tested:
Checked on
management -> OK
login -> OK
setup -> OK
portal -> OK

piwik data is sent for loading with language, for menu links, and all other publish events

All OK -> Verified
Comment 9 Stefan Gohmann univentionstaff 2017-04-04 18:29:54 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".