Bug 43695 - Add links to root certificate and the revocation list into the side menu
Add links to root certificate and the revocation list into the side menu
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Richard Ulmer
Florian Best
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-03-02 11:12 CET by Alexander Kläser
Modified: 2017-04-04 18:29 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2017-03-02 11:12:21 CET
In UCS 4.1, there are two entries on the UCS startsite for the root certificate and the revocation list. These links should be best viewed in the side menu in an additional submenu "Certificates". These menu entries need only to be visible on the master/backup system.
Comment 1 Florian Best univentionstaff 2017-03-02 16:59:51 CET
Alternatively they could also be shown as portal entries. But your suggestion might be better.
Comment 2 Florian Best univentionstaff 2017-03-02 17:00:27 CET
If we implement comment #0 we have to remove the old entries from the ucs-overview.
Comment 3 Dirk Wiesenthal univentionstaff 2017-03-09 07:37:58 CET
(In reply to Florian Best from comment #2)
> If we implement comment #0 we have to remove the old entries from the
> ucs-overview.

This is already done by blacklisting these keys in the UCR module
Comment 4 Florian Best univentionstaff 2017-03-09 16:43:41 CET
(In reply to Dirk Wiesenthal from comment #3)
> (In reply to Florian Best from comment #2)
> > If we implement comment #0 we have to remove the old entries from the
> > ucs-overview.
> 
> This is already done by blacklisting these keys in the UCR module
I don't think blacklisting is a good idea because we need to keep this code forever then. Unsetting is better.
Comment 5 Alexander Kläser univentionstaff 2017-03-09 16:52:48 CET
The menu entries need to link to the master (via tools.status('ldap_master')). As this will only work in scenarios where the DNS can be resolved, please make sure that on the roles domaincontroller_master and domaincontroller_backup (via tools.status('server_role')) the link is relative. The menu entries can be added to management/univention-web/js/hooks/default_menu_entries.js.

The previous UCR variables entries can simply be removed from services/univention-apache/08univention-apache.inst and in the postinst they can be unset as Florian said.

(In reply to Florian Best from comment #4)
> (In reply to Dirk Wiesenthal from comment #3)
> > (In reply to Florian Best from comment #2)
> > > If we implement comment #0 we have to remove the old entries from the
> > > ucs-overview.
> > 
> > This is already done by blacklisting these keys in the UCR module
> I don't think blacklisting is a good idea because we need to keep this code
> forever then. Unsetting is better.

I would vote for both, i.e., blacklisting + unsetting.
Comment 6 Richard Ulmer univentionstaff 2017-03-13 11:53:33 CET
The ucr entries will get unset now:
svn commit: 77579 + 77625
build: 9.0.3-2A~4.2.0.201703131135

The certificates-menu has been added:
svn commit: 77580 + 77629
build: 1.0.36-5A~4.2.0.201703131139
Comment 7 Florian Best univentionstaff 2017-03-13 12:03:16 CET
REOPEN: This changed the prior synchronous call of umc/hooks! to an asynchronous  require(). The umcConfig.callback() expects that umc/hooks! is executed before the callback is executed which is not anymore the case.
Comment 8 Florian Best univentionstaff 2017-03-13 12:07:07 CET
The translation is missing.
Comment 9 Florian Best univentionstaff 2017-03-13 13:19:06 CET
(In reply to Florian Best from comment #8)
> The translation is missing.
Ah no, I confused en.po with de.po in your commit.
Comment 10 Florian Best univentionstaff 2017-03-14 14:41:38 CET
REOPEN:
Please change into:
if [ -n "$keys" ]; then ucr unset $keys; fi

if you don't escape $keys in the first /bin/dash will fail with:
sh: 9: [: ucs/web/overview/entries/admin/.../description: unexpected operator
Comment 11 Richard Ulmer univentionstaff 2017-03-15 15:02:28 CET
I've made the changes suggested by Florian in Comment #10. Thanks for the hint.

svn commit: 77735
build: 9.0.3-3A~4.2.0.201703151500
Comment 12 Florian Best univentionstaff 2017-03-16 14:54:35 CET
(In reply to Florian Best from comment #7)
> REOPEN: This changed the prior synchronous call of umc/hooks! to an
> asynchronous  require(). The umcConfig.callback() expects that umc/hooks! is
> executed before the callback is executed which is not anymore the case.
We solved this differently by providing login.onLogin() / login.onLogout() / login.addLink().
Comment 13 Florian Best univentionstaff 2017-03-17 14:38:57 CET
OK: local/relative links on a DC Master/Backup
OK: absolute links with FQDN to the DC Master on a DC Slave
OK: Code-Review
REOPEN: Changelog entry missing
Comment 14 Richard Ulmer univentionstaff 2017-03-17 15:03:19 CET
The changelog entry has now been added.

svn commit: 77893
Comment 15 Florian Best univentionstaff 2017-03-17 15:16:22 CET
OK: Changelog entry
Comment 16 Stefan Gohmann univentionstaff 2017-04-04 18:29:45 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".