Bug 43838 - App Setting: Run configure script
App Setting: Run configure script
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.1
Other All
: P5 normal (vote)
: UCS 4.1-4-errata
Assigned To: Dirk Wiesenthal
Felix Botner
:
: 42839 (view as bug list)
Depends on: 43816 44755
Blocks: 44750
  Show dependency treegraph
 
Reported: 2017-03-13 18:32 CET by Dirk Wiesenthal
Modified: 2017-06-28 15:55 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2017-03-13 18:32:50 CET
After setting are applied, a Script should be run.

myapp.configure

Default is No Script, i.e. no execution, even for appbox.

No arguments except
  --app myapp --app-version 1.0 --error-file /tmp/XXX

The script shall apply settings saved earlier. By parsing base.conf manually.

Thus, settings have to be stored independently from configure.

Exiting with an error shall not abort the App Center.

+++ This bug was initially created as a clone of Bug #43816 +++

Goal is to allow Apps to specify custom setting that are then applied inside the container / on the host.

Specification is done via a new file: myapp.settings with is dritten in ini format:

[my/setting]
...
[my/second/setting]
...
Comment 1 Dirk Wiesenthal univentionstaff 2017-04-07 10:11:47 CEST
*** Bug 42839 has been marked as a duplicate of this bug. ***
Comment 2 Dirk Wiesenthal univentionstaff 2017-05-29 09:49:58 CEST
A configure script has been added in
  univention-appcenter (5.0.23-69)

It is called at the end of
  univention-app configure
which is also part of univention-app install.

I have also added a test case for this bug. But I did not get to pass. In my manual tests, the feature works, though. Maybe you can have a look.

After successful QA, please clone to 4.2-0-errata.

BTW: univention-app shell $app ucr set ...
does not trigger it. For appbox, this has been equivalent to univention-app configure, but was always discouraged. Now they actually differ.
Comment 3 Felix Botner univentionstaff 2017-06-01 18:12:47 CEST
Please also add "configure" support in uivention-app dev-regenerate-meta-inf and repo-ng create_appcenter_json.py.
Comment 4 Dirk Wiesenthal univentionstaff 2017-06-07 13:51:34 CEST
(In reply to Felix Botner from comment #3)
> Please also add "configure" support in uivention-app dev-regenerate-meta-inf
> and repo-ng create_appcenter_json.py.

Done. Live in create_appcenter_json.py and also in the App Provider Portal
Comment 5 Felix Botner univentionstaff 2017-06-08 13:05:02 CEST
OK - appcenter runs configure script
OK - yaml

fixed the test
merge to 4.2 -> Bug #44750
Comment 6 Janek Walkenhorst univentionstaff 2017-06-28 15:55:04 CEST
<http://errata.software-univention.de/ucs/4.1/432.html>