Bug 44007 - Adapt UVMM umc module to 4.2
Adapt UVMM umc module to 4.2
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Virtual machines (UVMM)
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Jürn Brodersen
Erik Damrose
: interim-4
: 37092 42656 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-03-21 15:55 CET by Erik Damrose
Modified: 2017-07-21 11:06 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
uvmm umc module in RC (67.23 KB, image/png)
2017-03-21 15:55 CET, Erik Damrose
Details
Screenshots of drives and network interfaces (89.24 KB, image/png)
2017-03-21 17:48 CET, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Damrose univentionstaff 2017-03-21 15:55:37 CET
Created attachment 8606 [details]
uvmm umc module in RC

The UVMM UMC module has to be adapted to the 4.2 design:

* The treeview should show all servers when opening the module - similar to the ldap module treeview
* The treeview should not show '+' signs on servers, as in 4.1
* Missing icons on servers
* On a running VM the CPU usage column is not looking correctly
* Button icons are not aligned
Comment 1 Alexander Kläser univentionstaff 2017-03-21 17:48:07 CET
Created attachment 8608 [details]
Screenshots of drives and network interfaces

Also the grids for drives and network interfaces need to be adjusted. IMHO we also should remove the hint "x entries from N selected" to narrow down the header a bit.
Comment 2 Erik Damrose univentionstaff 2017-03-22 10:18:26 CET
Comment 1 seems to be browser dependent, in my chromium it looks good.

Another issue though - on the devices page, the grids do not grow in height (that is ok) but also do not show a scrollbar if more items are added
Comment 3 Erik Damrose univentionstaff 2017-03-22 12:22:46 CET
When the UVMM module is opened and the page is reloaded (F5), the module is not opened again. The browser console shows this error:

Error initializing module uvmm: TypeError: win.global.window.getViewport is not a function
    at Object.postCreate (uvmm.js:366)
    at Object.create (dojo.js.uncompressed.js:12151)
    at Object.postscript (dojo.js.uncompressed.js:12064)
    at new <anonymous> (dojo.js.uncompressed.js:9902)
    at Object.<anonymous> (main.js:1455)
    at dojo.js.uncompressed.js:2866
    at d (dojo.js.uncompressed.js:5978)
    at k (dojo.js.uncompressed.js:5969)
    at b.resolve (dojo.js.uncompressed.js:6133)
    at Object.<anonymous> (main.js:1047)
Comment 4 Erik Damrose univentionstaff 2017-03-22 12:29:27 CET
The progress bar does not disappear after a snapshot was created (command/uvmm/snapshot/create returns with 200)
Comment 5 Erik Damrose univentionstaff 2017-03-22 12:48:55 CET
The grid content is updated automatically every x seconds to reflect changes in VM state. Currently, this causes the browser to scroll to the top
Comment 6 Jürn Brodersen univentionstaff 2017-03-22 14:22:35 CET
Chromium is autofilling boot order and vnc password if you stored credentials for umc. That prevents any changes because e.g. "Administrator" is not a valid boot order... :)
Comment 7 Florian Best univentionstaff 2017-03-22 18:26:57 CET
I guess we need to remove the umcIconAdd and umcIconDelete icon classes?

virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js:»   »   »   »   »   iconClass: 'umcIconAdd',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js:»   »   »   »   »   iconClass: 'umcIconAdd',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js:»   »   »   »   iconClass: 'umcIconAdd',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/DriveGrid.js:»   »   »   »   »   iconClass: 'umcIconAdd',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/InterfaceGrid.js:»   »   »   »   »   iconClass: 'umcIconAdd',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/SnapshotGrid.js:»   »   »   »   »   iconClass: 'umcIconAdd',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js:»   »   »   »   iconClass: 'umcIconDelete',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js:»   »   »   »   »   iconClass: 'umcIconDelete',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js:»   »   »   »   iconClass: 'umcIconDelete',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/DriveGrid.js:»   »   »   »   »   iconClass: 'umcIconDelete',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/InterfaceGrid.js:»   »   »   »   »   iconClass: 'umcIconDelete',
virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm/SnapshotGrid.js:»   »   »   »   »   iconClass: 'umcIconDelete',
Comment 8 Florian Best univentionstaff 2017-03-23 16:04:50 CET
*** Bug 37092 has been marked as a duplicate of this bug. ***
Comment 9 Erik Damrose univentionstaff 2017-03-23 16:45:52 CET
The module always sets the keyboard layout for new instances as en_us, regardless of system settings, this was different in 4.1
Comment 10 Jürn Brodersen univentionstaff 2017-03-24 13:28:26 CET
r78150: prevent chrome from autofilling vnc_password with umc
credentials
r78216: remember grid scroll position on grid update
r78164: fix getting the viewport width on reload
r78166: add autoExpand option to tree widget
r78265: move uvmm specific css rules into uvmm module
r78211: fix uvmm grid icons
r78131: Adjust grid height and footerFormater
r78188: fix tree icons
r78265: move uvmm specific css rules into uvmm module
r78268: add css rules for grid
r78280: changelog
r78283: revert wrong commited file in r78280
Comment 11 Jürn Brodersen univentionstaff 2017-03-24 15:43:17 CET
r78300: improved css
Comment 12 Erik Damrose univentionstaff 2017-03-27 12:00:12 CEST
It looks and feels great in chromium and firefox!

Two small issues i would like to see fixed:
* In the physical server view, the memory column does not look correct
* Remembering the scroll position: Works most of the times, very nice. There is an issue, that the search textedit seems to get the default focus, and if i deselect it (by left-clicking on empty space), the view will scroll up when the grid is refreshed, and the searchbox then has the focus.
Comment 13 Jürn Brodersen univentionstaff 2017-03-27 13:43:25 CEST
(In reply to Erik Damrose from comment #12)
> It looks and feels great in chromium and firefox!
> 
> Two small issues i would like to see fixed:
> * In the physical server view, the memory column does not look correct
> * Remembering the scroll position: Works most of the times, very nice. There
> is an issue, that the search textedit seems to get the default focus, and if
> i deselect it (by left-clicking on empty space), the view will scroll up
> when the grid is refreshed, and the searchbox then has the focus.

Fixed:
r78350: fix memory usage css; fix scroll issue; fix cpu usage for physical servers

This also repairs the cpu column for physical servers which was always empty.
Comment 14 Erik Damrose univentionstaff 2017-03-27 14:49:10 CEST
Great, works as expected -> Verified
Comment 15 Stefan Gohmann univentionstaff 2017-04-04 18:29:05 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".
Comment 16 Florian Best univentionstaff 2017-07-21 11:06:40 CEST
*** Bug 42656 has been marked as a duplicate of this bug. ***