Bug 44065 - Use new functions in old lib
Summary: Use new functions in old lib
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: App Center
Version: UCS 4.2
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 4.2
Assignee: Dirk Wiesenthal
QA Contact: Felix Botner
URL:
Keywords: interim-3
Depends on:
Blocks:
 
Reported: 2017-03-24 12:16 CET by Dirk Wiesenthal
Modified: 2017-04-04 18:29 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2017-03-24 12:16:44 CET
With Bug#40064 not yet fixed, we need to patch the old lib.

Functions of the new lib are better maintained. In order to reduce the costs of maintaining two versions of the App Center lib, we should integrate these functions in the old lib.

There are three places where old functions are clearly not working as expected.

Application.update_conffiles()
  does not honor the Apache conf files. Although as of now, only Docker Apps are relevant for these files, we should not wait until it becomes a problem
Application._set_ucr_codes_variable()
  the old class simply does not know about 4.1 Apps and cannot mark them as installed
  (In fact Application.all_installed() is wrong, but I do not want to fix that... just don't ever use this function...)
Application._send_information()
  sends more information in the new functions, notably 'system-uuid'

Hope this covers all relevant cases.
Comment 1 Dirk Wiesenthal univentionstaff 2017-03-24 12:24:04 CET
One could think about a backport... easy to do and works without Bug#43496 where it originally originated from.

Application.update_conffiles()
  -> update()._update_conffiles()
Application._set_ucr_codes_variable
  -> register._register_installed_apps_in_ucr()
Application._send_information()
  -> utils.send_information()

Note that methods starting with "_" should not be used outside of the new lib. But here it is okay, I think. Especially as we plan to remove the old code completely.

univention-appcenter 6.0.4-3A~4.2.0.201703241220
Comment 2 Felix Botner univentionstaff 2017-03-24 14:07:42 CET
OK
Comment 3 Stefan Gohmann univentionstaff 2017-04-04 18:29:18 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".