Bug 44144 - admember.py doesn't stop samba properly
admember.py doesn't stop samba properly
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: AD Connector
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2-0-errata
Assigned To: Arvid Requate
Stefan Gohmann
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-03-30 11:37 CEST by Arvid Requate
Modified: 2017-05-03 15:16 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
fix_samba_stop_in_admember_setup.patch (1.96 KB, patch)
2017-03-30 11:37 CEST, Arvid Requate
Details | Diff
fix_samba_stop_in_admember_setup.patch (1.46 KB, patch)
2017-03-30 11:39 CEST, Arvid Requate
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2017-03-30 11:37:14 CEST
Created attachment 8688 [details]
fix_samba_stop_in_admember_setup.patch

The admember.py doesn't stop samba properly:

1. It tries to stop "samba4" which doesn't exists any longer for some time

2. It uses invoke-rc.d, which doesn't work with the "samba" init script any longer in combination with systemd

Patch attached.

+++ This bug was initially created as a clone of Bug #44118 +++
Comment 1 Arvid Requate univentionstaff 2017-03-30 11:39:27 CEST
Created attachment 8689 [details]
fix_samba_stop_in_admember_setup.patch

cleaned up patch
Comment 2 Arvid Requate univentionstaff 2017-04-24 19:22:59 CEST
Package rebuilt in errata4.2-0 with patch.

Advisory: univention-lib.yaml
Comment 3 Stefan Gohmann univentionstaff 2017-05-03 07:49:57 CEST
Code review: OK

Tests: OK

YAML: OK
Comment 4 Janek Walkenhorst univentionstaff 2017-05-03 15:16:15 CEST
<http://errata.software-univention.de/ucs/4.2/5.html>