Univention Bugzilla – Bug 44313
37_import-networks_via_cli revealed regression in import_networks after superordinate changes
Last modified: 2017-04-18 14:30:03 CEST
http://jenkins.knut.univention.de:8080/job/UCSschool%204.2/job/UCSschool%204.2%20Singleserver/ImportTests=ImportTests,SambaVersion=s4/27/testReport/junit/90_ucsschool/37_import-networks_via_cli/test/ (2017-04-06 09:14:58.921450) Traceback (most recent call last): (2017-04-06 09:14:58.921479) File "/usr/share/ucs-school-import/scripts/import_networks", line 3190, in <module> (2017-04-06 09:14:58.932061) import_networks() (2017-04-06 09:14:58.932119) File "/usr/share/ucs-school-import/scripts/import_networks", line 2029, in import_networks (2017-04-06 09:14:58.932414) success, dn = create_network(schoolNr, network, iprange=iprange, defaultrouter=defaultrouter, nameserver=nameserver, netbiosserver=netbiosserver) (2017-04-06 09:14:58.932470) File "/usr/share/ucs-school-import/scripts/import_networks", line 1806, in create_network (2017-04-06 09:14:58.932740) set_router_for_subnet(network, defaultrouter, schoolNr) (2017-04-06 09:14:58.932789) File "/usr/share/ucs-school-import/scripts/import_networks", line 2219, in set_router_for_subnet (2017-04-06 09:14:58.933094) return set_policy_for_dhcp_subnet(network, schoolNr, policy_dhcp_routing_module, dn, values['name'], values=values, overwrite_policy=overwrite_policy) (2017-04-06 09:14:58.933146) File "/usr/share/ucs-school-import/scripts/import_networks", line 2122, in set_policy_for_dhcp_subnet (2017-04-06 09:14:58.933437) base=baseDN, filter=univention.admin.filter.expression('cn', str(network.network)) (2017-04-06 09:14:58.933484) File "/usr/lib/pymodules/python2.7/univention/admin/modules.py", line 743, in lookup (2017-04-06 09:14:58.962044) tmpres = module.lookup(co, lo, filter, base=base, superordinate=superordinate, scope=scope, unique=unique, required=required, timeout=timeout, sizelimit=sizelimit) (2017-04-06 09:14:58.962107) File "/usr/lib/pymodules/python2.7/univention/admin/handlers/dhcp/__common.py", line 116, in lookup (2017-04-06 09:14:58.986258) for dn, attrs in lo.search(filter_str, base, scope, [], unique, required, timeout, sizelimit) (2017-04-06 09:14:58.986279) File "/usr/lib/pymodules/python2.7/univention/admin/handlers/__init__.py", line 596, in __init__ (2017-04-06 09:14:58.986289) self._validate_superordinate() (2017-04-06 09:14:58.986299) File "/usr/lib/pymodules/python2.7/univention/admin/handlers/__init__.py", line 620, in _validate_superordinate (2017-04-06 09:14:58.986310) if not set([self.superordinate.module]) & superordinate_names: (2017-04-06 09:14:58.986318) AttributeError: 'str' object has no attribute 'module' The import_networks script has not been fully adapted after superordinate changes.
By fixing the bugs #34764, #40649 and #42177 (superordinate handling) a regression has been introduced. This has been fixed. Package: ucs-school-import Version: 15.0.0-3A~4.2.0.201704062149 Branch: ucs_4.2-0 Scope: ucs-school-4.2 ucs-school-import (15.0.0-3): r78684 | Bug #44313: fixed import_networks after superordinate changes
OK: test works again
UCS@school 4.2 v1 has been released. http://docs.software-univention.de/release-notes-ucsschool-4.2v1-de.html If this error occurs again, please clone this bug.
The fix missed the DN escaping!!