Univention Bugzilla – Bug 44350
workgroup wizard cannot remove users from a workgroup
Last modified: 2017-06-23 13:33:13 CEST
The UMC wizard to manage workgroups can add but not remove users from a workgroup.
r78817: refactor for better readability r78818: fix UMC not removing users from workgroup Package: ucs-school-umc-groups Version: 6.0.4-2.83.201704181608 Branch: ucs_4.1-0 Scope: ucs-school-4.1r2
Before r78818 the UMC wizard did load the current group from LDAP (group_from_ldap) and checked its members for validity and modify-permissions. For example non-school users were removed. It did however not compare the resulting list ("users") with the one submitted by the user. So it was possible to add (valid) users, but users were never removed. With r78818 only those users remain in the group, that are part of both the resulting list ("users") and the one submitted by the user (group_from_umc['members']).
Created attachment 8835 [details] patch This was introduced by Bug #40539. The fix is incorrect, as it removes way more group members than only those de-selected (e.g. depending on the LDAP ACL's of the user, school overlapping things, non-school-groups). Attached is a untested patch which compares the old values with the new values directly.
(In reply to Florian Best from comment #3) > The fix is incorrect, as it removes way more group members than only those > de-selected (e.g. depending on the LDAP ACL's of the user, school > overlapping things, non-school-groups). > Attached is a untested patch which compares the old values with the new > values directly. Also depending on the used flavor. "workgroup-admin" shows all objects while "workgroup" shows only students. Therefore this flavor would remove every teacher from the group.
I think a customer reported this issue in Ticket #2017051821000315
79461: fix removing to many users (patch by fbest) 79462: update advisory ucs-school-umc-groups 7.0.0-5A~4.2.0.201705211327
Commits 78815 and 78816 belong really to UCS@school 4.2 Bug #44351.
79463: fix removing to many users (patch by fbest) 79464: update advisory ucs-school-umc-groups 6.0.4-3.84.201705211336
Created attachment 8867 [details] squashed patch @Christina: You can apply the patch with: patch -p5 -d /usr/share/pyshared/univention/management/console/modules/schoolgroups/ < 44351.patch
OK: fix OK: YAML
*** Bug 44712 has been marked as a duplicate of this bug. ***
UCS@school 4.1 R2 v12 has been released. http://docs.software-univention.de/changelog-ucsschool-4.1R2v12-de.html If this error occurs again, please clone this bug.