Univention Bugzilla – Bug 44625
Update UCS 4.2 app appliance integration
Last modified: 2017-07-26 12:22:19 CEST
We need to update the app appliance integration of UCS 4.2 (see Bug 44523).
I have added the necessary code to make the App appliance entries of UCS 4.2 work in the provider portal. As I had troubles setting up my local provider portal, I could not verify whether logo and ini files are created correctly. univention-management-console-module-appcenter-selfservice (1.0.0-152): r79451 | Bug #44625: Add new entries for UCS 4.2 App appliances
I needed to add l10n support for the portal title + appliance readme file. univention-management-console-module-appcenter-selfservice (1.0.0-153): r79453 | Bug #44625: Add localization for appliance fields + adjust ImageUploader
OK, works. From the code review, this seems to be wrong: if (this.value.indexOf('PHN2Z') === 0 || this.value.indexOf('PFNWR') === 0 || this.value.indexOf('PFhNT') || this.value.indexOf('PHhtb')) { return 'svg+xml'; } I guess (actually, I really guess), that you want a "=== 0" on the last two, too? Also, you removed appliance_umc_category_logo and -_modules. Is this not needed for 4.2 Appliances? Just asking. If this is only for 4.1, putting it in "Advanced / Custom settings" should be enough.
(In reply to Dirk Wiesenthal from comment #4) > OK, works. From the code review, this seems to be wrong: > > if (this.value.indexOf('PHN2Z') === 0 || this.value.indexOf('PFNWR') === 0 > || this.value.indexOf('PFhNT') || this.value.indexOf('PHhtb')) { > return 'svg+xml'; > } > > I guess (actually, I really guess), that you want a "=== 0" on the last two, > too? Oh, yes, your guess is quite correct. In the current state, SVG files starting with "<svg" or "<SVG" would not be detected as type SVG. I added Bug 45057 to fix this in UCS, as well. univention-management-console-module-appcenter-selfservice (1.0.0-159): r81335 | Bug #44625: adjust type in the image type detection > Also, you removed appliance_umc_category_logo and -_modules. Is this not > needed for 4.2 Appliances? Just asking. If this is only for 4.1, putting it > in "Advanced / Custom settings" should be enough. appliance_umc_category_logo → is obsolete for UCS 4.2 appliance_umc_modules → has been replaced with appliance_favorite_modules I discussed these changes with Erik.
OK, works.
Erik spotted a typo which I just fixed :) . univention-management-console-module-appcenter-selfservice (1.0.0-161): r81380 | Bug #44625: adjust typo for the appliance_portal_title attribute
OK, live.