Bug 44997 - Confusing Samba permissions & options in UMC shares module
Confusing Samba permissions & options in UMC shares module
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Shares
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-4
Assigned To: Florian Best
Dirk Wiesenthal
:
: 19868 21349 50701 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-13 16:23 CEST by Arvid Requate
Modified: 2023-06-21 09:24 CEST (History)
9 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 4: Will affect most installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.091
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2019050321000143
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2017-07-13 16:23:51 CEST
The various Samba share permissions & options are pretty complex by nature. Additionally the UMC presents them in a confusing way. E.g.

* The checkbox "Users with write access may modify permissions" is on the Samba tab instead of on the "Samba permissions" section of the "advanced" tab ([Erweiterte Einstellungen]).

* The checkbox "NT ACL Support" could be removed, because it's generally not a recommended option to disable this. If desired, it can be done in the "Samba custom settings".

* The checkbox matrix in the "Samba extended permissions" section is a minefield and some options are not "best practice" IMHO. To start with, I would recommend to remove the four "force" settings: "force create mode", "force directory mode", "force security mode" and "force directory security mode". Those Samba share level permissions are not transparent to Active Directory admins and just add a third level of complexity, additional to (1) the Posix permissions in the Linux backend and (2) the NTACLs accessible on the Windows frontend.

* The per share options to configure oplocks (& locks) don't seem useful to me. If a particular customer has oplock issues, you would probably disable them fully as a temporary workaround and not on a per share basis. Also this is not a common option to configure, which needs to be accessible conveniently via UMC.


As a rule of thump:

* We should only advertise options, that we consider useful in common cases

* We should offer options that can be combined to achieve "best practice" configuration (see Bug #44996), i.e. state of the art vs legacy configuration techniques
Comment 1 Christian Völker univentionstaff 2019-05-29 13:20:19 CEST
* The checkbox matrix in the "Samba extended permissions" section is a minefield and some options are not "best practice" IMHO. To start with, I would recommend to remove the four "force" settings: "force create mode", "force directory mode", "force security mode" and "force directory security mode". Those Samba share level permissions are not transparent to Active Directory admins and just add a third level of complexity, additional to (1) the Posix permissions in the Linux backend and (2) the NTACLs accessible on the Windows frontend.

Offering options in the "Erweiterte Samba Rechte" which do not exist should definitely be removed in UMC as well!

Customers really get confused by the possibility to configure things here.

Support is having regularly  questions about this from customers.
Comment 2 Dirk Ahrnke univentionstaff 2022-03-09 15:09:44 CET
still valid for UCS 5 and I think that not just an average number of installed domains is affected
Comment 3 Florian Best univentionstaff 2022-04-26 18:19:19 CEST
All points addressed in the MR https://git.knut.univention.de/univention/ucs/-/merge_requests/360.
Comment 5 Florian Best univentionstaff 2023-06-09 11:29:06 CEST
Each mentioned point has been addressed in a separate commit:

univention-directory-manager-modules (15.0.20-9)
62bb92141386 | Bug #44997: move "VFS objects" into "Samba options"
69e313c35940 | Bug #44997: move checkbox "Allow Samba Write access" into "Samba permissions"
51a3676981dc | Bug #44997: Turn VFS objects into a combobox
6af463e003b6 | Bug #44997: add long descriptions to various share options
53c637a7bb62 | Bug #44997: remove locking options
3c95ea175efb | Bug #44997: remove checkbox "NT ACL Support"
3f0df4f14a58 | Bug #44997: move checkbox "Users with write access may modify permissions" into "Samba permissions"
b3dcc9c25009 | Bug #44997: make checkboxes fit the whole size instead of breaking into mulitple lines
3fbfb0159bdc | Bug #44997: transform advanced settings tabs into Groups on the corresponding Samba/NFS tab
Comment 6 Florian Best univentionstaff 2023-06-09 11:45:24 CEST
*** Bug 19868 has been marked as a duplicate of this bug. ***
Comment 7 Florian Best univentionstaff 2023-06-09 11:45:48 CEST
*** Bug 50701 has been marked as a duplicate of this bug. ***
Comment 8 Florian Best univentionstaff 2023-06-09 11:54:17 CEST
*** Bug 21349 has been marked as a duplicate of this bug. ***
Comment 9 Dirk Wiesenthal univentionstaff 2023-06-19 12:17:23 CEST
OK: Tests
OK: Code review
OK: Descriptions and layout are way better
OK: Manual tests
OK: Changelog
Comment 10 Philipp Hahn univentionstaff 2023-06-21 09:24:42 CEST
UCS 5.0-4 has been released:
 https://docs.software-univention.de/release-notes/5.0-4/en/

If this error occurs again, please use the 'Clone This Bug' option.