Bug 45332 – Check school admin accounts

Bug 45332 - Check school admin accounts


Summary:	Check school admin accounts

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - System diagnostic
Version:	UCS@school 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.4 v7
Assigned To:	Toni Röhmeyer
QA Contact:	Tobias Wenzel

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-09-06 17:01 CEST by Sönke Schwardt-Krummrich
Modified:	2020-10-12 16:19 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Feature Request
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sönke Schwardt-Krummrich

2017-09-06 17:01:32 CEST

The diagnostic module should check if school admin accounts are correctly configured:
- user is member of OU admin group
- user object contains object class ucsschoolAdministrator

Comment 1 Toni Röhmeyer

2020-08-27 19:57:16 CEST

Added diagnosis module with commit

commit b6a08c6615da6e72f9c5ce11e6d04ac97064f1fb
Bug #45332: added diagnosis module for admin check

to branch troehmey/bug45332_check_school_admins

Comment 2 Tobias Wenzel

2020-09-28 14:20:59 CEST

QA -> REOPEN with some remarks

- In the first loop you only need/ use ucsschoolSchool
- If ucsschoolSchool is not set, a key-error is catched. Since the admin is a school admin, I would like to have, maybe slightly modified, message about this.
- if not admin["schools"] -> you don't really need this case
- I would skip the second for admin in admins loop and add the problematic objects at the end of the "admin" iteration. 


... other than that the code seems to be working.

Comment 3 Toni Röhmeyer

2020-10-01 09:48:20 CEST

Resolved issues with fixup commit:

c839e55c0 Bug #45332: added diagnosis module for admin check

Comment 4 Toni Röhmeyer

2020-10-01 11:55:11 CEST

Added one more fixup which checks that each member of an admin-school group is a ucsschoolAdministrator

Comment 5 Tobias Wenzel

2020-10-02 15:33:53 CEST

QA -> All Ok -> REOPEN for merge & build

Thanks for the changes!


As discussed, squash the commits, merge, add changelogs & yaml & build

Comment 6 Toni Röhmeyer

2020-10-02 17:10:25 CEST

Applied squash, merge and build.

Commits:

ffd692a0f Bug #45332: added yaml
a04efd470 Bug #45332: added changelog entry
3f7422387 Bug #45332: Merge branch 'troehmey/bug45332_check_school_admins' into 4.4


Successful build:

Package: ucs-school-umc-diagnostic
Version: 1.0.0-13A~4.4.0.202010021658
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Comment 7 Tobias Wenzel

2020-10-05 12:59:17 CEST

QA -> All OK -> VERIFY

Changelog -> OK
YAML -> OK

Comment 8 Daniel Tröder

2020-10-12 16:19:14 CEST

UCS@school 4.4 v7 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v7-de.html

If this error occurs again, please clone this bug.