Bug 45482 - (4.2) Traceback in ucs-school-ntlm-auth if stationId is not set
(4.2) Traceback in ucs-school-ntlm-auth if stationId is not set
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Radius
UCS@school 4.2
Other Linux
: P5 normal (vote)
: UCS@school 4.2 v4
Assigned To: Sönke Schwardt-Krummrich
Florian Best
:
Depends on: 44918 44919
Blocks: 45490
  Show dependency treegraph
 
Reported: 2017-10-04 18:09 CEST by Michel Smidt
Modified: 2017-10-16 21:34 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michel Smidt 2017-10-04 18:09:15 CEST
+++ This bug was initially created as a clone of Bug #44919 +++

Also implement this in UCS@school 4.2

+++ This bug was initially created as a clone of Bug #44918 +++

Debugging of ucs-school-ntlm-auth is hard since there is no feedback other than success/failed.

So we need some kind of logging for support/professional service/development.

+++ 

Unfortunately this changes leads to exceptions if the stationId is null.
Following debug statements fail:

debug('getNTPasswordHash: username=%r  stationId=%r' % (username, stationId.encode('hex')))
and
debug('getNTPasswordHash: username2=%r  stationId=%r' % (username, stationId.encode('hex')))

The problem here is that any local test fails but this local tests are the first think which I do with customers:
# radtest -t mschap testuser password localhost 10 testing123

So, the radius conf is not reasonable testable anymore.
If I comment the statments the logging output is very nice!
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2017-10-09 21:34:20 CEST
Fix: use '' instead of None as default

ucs-school-radius-802.1x.yaml:
9422fd05469d | Bug #45482: Merge branch 'sschwardt/45482/42/radius-ntlm-auth2' into 4.2
f14b4e73ca3d | Bug #45482: add advisory

ucs-school-radius-802.1x (6.0.1-3):
9422fd05469d | Bug #45482: Merge branch 'sschwardt/45482/42/radius-ntlm-auth2' into 4.2
49a34ca8a3c7 | Bug #45482: add changelog entry
249af772ac98 | Bug #45482: fix traceback if stationId is not specified

Package: ucs-school-radius-802.1x
Version: 6.0.1-3A~4.2.0.201710092131
Branch: ucs_4.2-0
Scope: ucs-school-4.2
Comment 2 Florian Best univentionstaff 2017-10-10 19:21:58 CEST
OK: fix
OK: YAML
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2017-10-16 21:32:09 CEST
UCS@school 4.2 v4 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.2v4-de.html

If this error occurs again, please clone this bug.