Bug 45729 – o365 connector group listener does not support modifying in different workflow

Bug 45729 - o365 connector group listener does not support modifying in different workflow


Summary:	o365 connector group listener does not support modifying in different workflow

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Office 365
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.2
Assigned To:	Daniel Tröder
QA Contact:	Erik Damrose

URL:
Keywords:

Depends on:
Blocks:	46513
	Show dependency tree / graph

Reported:	2017-11-17 12:32 CET by Andreas Peichert
Modified:	2018-03-22 09:36 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.086
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Peichert

2017-11-17 12:32:53 CET

This will work:
Empty group: modify group and activating o365 settings, adding Azure members afterwards → successfully synced to Azure AD

But the more common workflow does not work:
Group with already Azure members associated: modify group and activating o365 settings afterwards → results in a Traceback

Traceback (most recent call last):
  File "/usr/lib/univention-directory-listener/system/office365-group.py", line 169, in handler
    azure_group = ol.modify_group(old, new)
  File "/usr/lib/pymodules/python2.7/univention/office365/listener.py", line 337, in modify_group
    return dict(objectId=old["univentionOffice365ObjectID"][0])
KeyError: 'univentionOffice365ObjectID'
16.11.17 17:28:37.049  LISTENER    ( WARN    ) : handler: office365-group (failed)

(Note: Found in Multi-Teant environment)

Comment 1 Daniel Tröder

2018-02-21 10:08:33 CET

[4.2 65ace7d] Bug #45729: handle activating group that already has Azure users

univention-office365 (1.0.1-9)

Cannot be tested this week, as the test accounts are required elsewhere.

Comment 2 Daniel Tröder

2018-03-01 21:10:39 CET

[4.2 5683772] Bug #45729: no need to search for udm_groups_with_azure_users twice: if result is an empty list nothing will happen
[4.2 8ad0224] Bug #45729: UMC wizard package and main package musthave same version
[4.2 37d61b3] Bug #45729: handle "Subscription with SKU ... does not have any available licenses."
[4.2 b23f27b] Bug #45729: changelog

univention-office365 (1.0.1-11)

Most of the available ucs-tests (in 92_office365) worked. Those that didn't are probably errors in the tests. But that should be verified on a different machine.

Comment 3 Erik Damrose

2018-03-21 11:49:24 CET

Verified

Comment 4 Erik Damrose

2018-03-22 09:36:22 CET

Closed: App Update has been released