Bug 45730 - [4.3] No class room selection by default
[4.3] No class room selection by default
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Exam mode
UCS@school 4.1 R2
Other Mac OS X 10.1
: P5 normal (vote)
: UCS@school 4.3 v4
Assigned To: Ole Schwiegert
Jürn Brodersen
:
Depends on:
Blocks: 46883
  Show dependency treegraph
 
Reported: 2017-11-17 12:38 CET by Michel Smidt
Modified: 2018-07-04 18:08 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michel Smidt 2017-11-17 12:38:44 CET
The customer reported that the default room selection box is not very handy for the usual teacher. Several teachers seems to use the preselected room by accident. So, I would prefer no class room selection by default so that every teacher explicitly has to select the right room.

And the bug #31179 would be very useful as well!
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2018-03-20 10:24:42 CET
Please check if exam mode automatically determines the room based on the user's IP address.

An additional entry "<please select room>" should be added to the room combo box. The wizard should refuse the next steps if a valid room has not yet been selected.

Please also check whether a default room can still be set using the UCR variable. Is this UCR variable documented in the manual? If not, please complete the manual accordingly.
Comment 2 Ole Schwiegert univentionstaff 2018-03-23 11:18:34 CET
As far as I understood the code, the exam mode doesn't determine the room based on user's IP but does respect the ucsschool/exam/default/room variable which works and is well documented in the manual

A <please select a room> entry was added and the user cannot proceed in the wizard unless a real room was chosen. There was a problem with the validation code though which I documented in code. Instead of using the validate function of the ComboBox I had to validate in the Wizards next method. Maybe someone more experienced in the framework should have a look since I could not find the reason for the current behavior.

Localization is not yet included in the patch and has to be added before merging. Also the manuals entry on the default variable has to be altered if this feature request is merged. (The default value if the variable is not set is not anymore the first alphanumerical entry in the list)

Gitlab branch: oschwieg/45730
Comment 3 Ole Schwiegert univentionstaff 2018-04-11 13:45:06 CEST
After discussing with Sönke and Johannis we just set the initial value of the ComboBox to null if there is no default room and let the required-validation do the rest of the work. There is no <please select a room> entry anymore.
Comment 4 Ole Schwiegert univentionstaff 2018-04-26 12:52:03 CEST
Package: ucs-school-umc-exam
Version: 8.0.2-1A~4.3.0.201804261249
Comment 5 Jürn Brodersen univentionstaff 2018-05-04 16:59:22 CEST
OK
No room is selected and ucsschool/exam/default/room still works
Comment 6 Sönke Schwardt-Krummrich univentionstaff 2018-07-04 18:08:58 CEST
UCS@school 4.3 v4 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.3v4-de.html

If this error occurs again, please clone this bug.