Bug 45819 - Welcome screen typo: "addresses" should be singular
Welcome screen typo: "addresses" should be singular
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.2
Other Linux
: P5 minor (vote)
: UCS 4.3
Assigned To: Richard Ulmer
Florian Best
: interim-2
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-05 12:26 CET by Richard Ulmer
Modified: 2018-03-14 14:38 CET (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 4: Will affect most installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.023
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
The falsly used plural (770.85 KB, image/png)
2017-12-05 12:49 CET, Richard Ulmer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Ulmer univentionstaff 2017-12-05 12:26:57 CET
After installing UCS the welcome screen advises you to "Navigate to one of the following addresses:", although only one entry (https://IP) follows.
Comment 1 Richard Ulmer univentionstaff 2017-12-05 12:35:41 CET
Patch commit: 0160f4f60b0a747a780eb55127b64d13fcd96545
Comment 2 Richard Ulmer univentionstaff 2017-12-05 12:49:34 CET
Created attachment 9301 [details]
The falsly used plural
Comment 3 Richard Ulmer univentionstaff 2017-12-05 12:50:28 CET
The mentioned patch can be found in the branch rulmer/Bug45819
Comment 4 Erik Damrose univentionstaff 2017-12-05 13:06:58 CET
Have you tried configuring multiple ethernet interfaces for the system? If more than one interface is defined, they all should show up on the welcome screen. We call get_all_ip_addresses in the univention-welcome-screen script to get them.

Your current patch fixes the sentence for one configured interface, but now the statement is wrong if more than one is configured.
Comment 5 Florian Best univentionstaff 2017-12-05 13:13:08 CET
(In reply to Erik Damrose from comment #4)
> Have you tried configuring multiple ethernet interfaces for the system? If
> more than one interface is defined, they all should show up on the welcome
> screen. We call get_all_ip_addresses in the univention-welcome-screen script
> to get them.
> 
> Your current patch fixes the sentence for one configured interface, but now
> the statement is wrong if more than one is configured.

We had an explicit change in the welcome screen - for usability reasons - so that only one address is displayed. The FQDN is not shown anymore because it's not resolveable everywhere. I don't think that showing multiple IP addresses is currently done and probably shouldn't.
This typo was also recognized in one of our usability studies.
I think the patch is good.
Comment 6 Richard Ulmer univentionstaff 2018-01-10 09:30:22 CET
The changes have been merged and built now.

changelog-4.3-0.xml:
64bacd516a83 | Bug #45819: Add changelog entry

univention-bootsplash (9.0.0-4):
80fad7ceea4c | Bug #45819: Fix typo
2bc935aa5e96 | Bug #45819: Fix typo
Comment 7 Florian Best univentionstaff 2018-01-10 18:32:42 CET
OK: looks good
~OK: changelog entry
Comment 8 Stefan Gohmann univentionstaff 2018-03-14 14:38:22 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".