Bug 45963 - postfix main.cf and init script needs to be adjusted for UCS 4.3
postfix main.cf and init script needs to be adjusted for UCS 4.3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Mail
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Daniel Tröder
Sönke Schwardt-Krummrich
: interim-2
Depends on:
Blocks: 45968 47117
  Show dependency treegraph
 
Reported: 2017-12-29 11:08 CET by Florian Best
Modified: 2018-06-04 08:29 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2017-12-29 11:08:58 CET
In UCS 4.3 postfix doesn't start because the old init script and the old main.cf is used - which is incompatible with the new version.
All mail tests are failing therefore because port 25 is closed.
Comment 1 Daniel Tröder univentionstaff 2018-01-02 16:22:30 CET
Fixed a test:

3adf67eb: handle not-returning openssl call

Package: ucs-test
Version: 8.0.7-2A~4.3.0.201801021618


Postfix 3 has a "Backwards-Compatibility Safety Net" (http://www.postfix.org/COMPATIBILITY_README.html) which is activated.
All listed configuration options are now set explicitly, but the compatibility mode has not been deactivated, because users might set custom options in their main.cf.local file.
If a customer wishes, the compatibility-mode can be deactivated with "compatibility_level=3" in main.cf.local.

7ddb47aa: adapt configuration and init script to stretch
c625a0dd: changelog
114bddc3: update copyright

univention-mail-postfix 12.0.0-3A~4.3.0.201801021556
Comment 2 Daniel Tröder univentionstaff 2018-01-02 18:07:34 CET
[4.3-0 871e5bda15] Bug #45963: add missing UCR declaration

univention-mail-postfix 12.0.0-4A~4.3.0.201801021805
Comment 3 Daniel Tröder univentionstaff 2018-01-03 09:24:33 CET
Apparently the Postfix config parser doesn't support comments behind values.

c626d1e5: fix config
c19454bf: changelog

univention-mail-postfix 12.0.0-5A~4.3.0.201801030919
Comment 4 Daniel Tröder univentionstaff 2018-01-04 12:54:29 CET
Apparently the init script checks the master.cf if it needs to maintain the chroot environment, and the backwards compatibility settings make "-" to "y". I set it to be explicitly "y" (partially reverting 7ddb47aa), so when a user would set the compatibility mode to "3" to get rid of the warning message, he will not end up with an unmaintained chroot.

IMHO we should either disable all use of the chroot or configure all daemons to run there. 

2ad1197e: force init script to maintain chroot environment

univention-mail-postfix 12.0.0-6A~4.3.0.201801041244
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2018-02-25 22:26:32 CET
Why have you set "mynetworks_style"? This option is only used to determine the default value of "mynetworks", but "mynetworks" is always set via the UCR template. So there is currently no change in behaviour 
→ OK for me.

root@master:~# postconf compatibility_level
postconf: warning: compatibility_level: unknown parameter
root@master:~# lsb_release -r
Release:        4.2-3 errata284

root@master:~# postconf compatibility_level
compatibility_level = 0
root@master:~# lsb_release -r
Release:        4.3-0 errata0

OK: code change
??: functional test
OK: release notes/changelog
??: did a small change to a ucs-test script → wait for jenkins results

Fixed some UCR variable descriptions:

Package: univention-mail-postfix
Version: 12.0.0-13A~4.3.0.201802252224
Branch: ucs_4.3-0
Comment 6 Daniel Tröder univentionstaff 2018-02-26 08:52:54 CET
(In reply to Sönke Schwardt-Krummrich from comment #5)
> Why have you set "mynetworks_style"? This option is only used to determine
> the default value of "mynetworks", but "mynetworks" is always set via the
> UCR template. So there is currently no change in behaviour 
> → OK for me.
Yes - it doesn't change anything of us now. But my intention was to have two things:
* Make changes of configuration defaults explicit (or at least documented).
* To get rid of all compatibility warnings.
To achieve the latter, the first must be done: the settings that got its defaults changed must be set explicitly.
Comment 7 Daniel Tröder univentionstaff 2018-03-01 09:21:15 CET
Commit "[4.3-0 ce9701a8b7] Bug #45984: don't disable connection caching on postfix' amavis port" was accidentally labeled for Bug #45984, though it was meant for this bug and should have been named "enable chroot'ing of scache service". The packages changelog was modified to reflect this with commit [4.3-0 4cbbf0a884]. Actually there was confusion as well, so another commit fixes it (no package rebuild though): [4.3-0 f4fddc0889] Bug #45963: fix changelog entry
Comment 8 Sönke Schwardt-Krummrich univentionstaff 2018-03-01 18:17:33 CET
(In reply to Sönke Schwardt-Krummrich from comment #5)
> OK: code change
> ??: functional test
> OK: release notes/changelog
> ??: did a small change to a ucs-test script → wait for jenkins results
OK: functional test
OK: test scripts


(In reply to Daniel Tröder from comment #6)
> Yes - it doesn't change anything of us now. But my intention was to have two
> things:
> * Make changes of configuration defaults explicit (or at least documented).
> * To get rid of all compatibility warnings.
> To achieve the latter, the first must be done: the settings that got its
> defaults changed must be set explicitly.
→ OK

→ VERIFIED
Comment 9 Stefan Gohmann univentionstaff 2018-03-14 14:38:05 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".