Bug 46175 - Unify locked and disabled handling
Unify locked and disabled handling
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: General
unspecified
Other Linux
: P5 normal (vote)
: UCS@school 4.3 v1
Assigned To: Florian Best
Sönke Schwardt-Krummrich
: interim-2
Depends on: 32014 39817 46200
Blocks:
  Show dependency treegraph
 
Reported: 2018-01-26 15:23 CET by Florian Best
Modified: 2018-03-14 13:11 CET (History)
6 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.171
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2018-01-26 15:23:02 CET
disabled changed from ('all', 'none') to ('1', '0').
locked changed from ('all', 'none') to locked=="1" (read only) and unlock="1".

+++ This bug was initially created as a clone of Bug #39817 +++
Comment 1 Florian Best univentionstaff 2018-01-26 15:23:51 CET
Feature branch: fbest/46175-unify-disabled-locked
Comment 2 Florian Best univentionstaff 2018-01-31 13:52:21 CET
Changes have been merged.

ucs-school-import (16.0.1-1)
3817f4e390f0 | Bug #46175: Merge branch 'fbest/46175-unify-disabled-locked' into 4.3
0169889cb9d8 | Bug #46175: adapt to API change of "disabled" property

cc327a36bc76 | Bug #46175: adapt to API change of "disabled" property

ucs-test-ucsschool (5.0.2-2)
3817f4e390f0 | Bug #46175: Merge branch 'fbest/46175-unify-disabled-locked' into 4.3
ed32a196452e | Bug #46175: adapt test cases to API change

ucs-school-info (8.0.1-1)
3817f4e390f0 | Bug #46175: Merge branch 'fbest/46175-unify-disabled-locked' into 4.3
3767b5c69ae5 | Bug #46175: adapt to API change of "disabled" property

ucs-school-lib (11.0.1-1)
3817f4e390f0 | Bug #46175: Merge branch 'fbest/46175-unify-disabled-locked' into 4.3
16abea789709 | Bug #46175: adapt to API change of "disabled" property
Comment 3 Florian Best univentionstaff 2018-01-31 19:25:16 CET
Hmm, ucs-school-umc-users sets locked=0. Prior locked=0 resettet the "!" in userPassword. Now disabled=0 does this. We probably should add disabled=0 ?!.
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2018-03-09 16:09:04 CET
(In reply to Florian Best from comment #3)
> Hmm, ucs-school-umc-users sets locked=0. Prior locked=0 resettet the "!" in
> userPassword. Now disabled=0 does this. We probably should add disabled=0 ?!.

No, I don't think so. The password reset performed by teachers should be able to unlock (locked==1) users that have been locked e.g. by Samba. But they should not be able to (re)activate user accounts that have been disabled on purpose by Domain Admins.

OK: code change
OK: functional change
OK: manual test
    → the UMC module "Passwörter (Schüler)" only unlocks a user (if locked==1) and 
      keeps the current state of "disabled"
OK: advisory entry not required / no functional change for customers
OK: package built
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2018-03-14 13:11:52 CET
UCS@school 4.3 v1 has been released.

https://docs.software-univention.de/release-notes-ucsschool-4.3v1-de.html

If this error occurs again, please clone this bug.