Bug 46255 - Check UCR templates files for Debian-Stretch updates - mail/univention-spamassassin
Check UCR templates files for Debian-Stretch updates - mail/univention-spamas...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Spamassassin
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Daniel Tröder
Jannik Ahlers
: interim-2
Depends on:
Blocks: 46120
  Show dependency treegraph
 
Reported: 2018-02-08 13:52 CET by Philipp Hahn
Modified: 2018-03-14 14:38 CET (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments
Screenshot (20.81 KB, image/png)
2018-02-22 11:06 CET, Jannik Ahlers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2018-02-08 13:52:55 CET
+++ This bug was initially created as a clone of Bug #46120 +++

usr/share/spamassassin/10_misc.cf
- duplicates most of /usr/share/spamassassin/10_default_prefs.cf
- rename?
- move only the overwriting part to /etc/spamassassin/90_univention.cf
(See <https://spamassassin.apache.org/full/3.2.x/doc/spamassassin.txt> for a description of the configuration fragment preference order)

proposed patch: <https://git.knut.univention.de/univention/ucs/commit/2a2483eb8231184dc720f41278ecf31d989c02c8>
Comment 1 Daniel Tröder univentionstaff 2018-02-20 10:29:57 CET
Thank you. This way it'll be easier to adapt to changes by upstream.

I merged the patch to 4.3-0 (4b501d09) and built the package:
univention-spamassassin (9.0.0-3).

It installs and sa runs as expected.

No changelog required, as nothing changed for the end user.
Comment 2 Jannik Ahlers univentionstaff 2018-02-22 09:33:56 CET
OK: new config file 90_univention.cf gets stored in the right place
OK: ucr variables seem to work
OK: spamassassin runs as expected

After changing the ucr variabl email/antispam/requiredhits to 6.0 and restarting amavis, postfix and spamassassin, the spam-level value in horde still defaults to 5. Is this correct behaviour?
Comment 3 Daniel Tröder univentionstaff 2018-02-22 10:35:53 CET
It is mail/antispam/requiredhits, without an 'e' at the beginning.

I have no horde installation atm to look at the code, but my guess is, that you are referring to a Sieve script. That would be generated per user only once, and not updated upon changing the UCR (except through a listener module resync).
Comment 4 Jannik Ahlers univentionstaff 2018-02-22 11:06:15 CET
Created attachment 9414 [details]
Screenshot

the e was a typo in the comment only. 
to me it looks like this value should've been set to the ucr variable initially, but i also wasn't sure if it should.
Is there another way to test if the values are being used by spamassassin?
Comment 5 Daniel Tröder univentionstaff 2018-02-22 11:14:18 CET
(In reply to Jannik Ahlers from comment #4)
> to me it looks like this value should've been set to the ucr variable
> initially, but i also wasn't sure if it should.
No idea - you'd have to look into the PHP code, where it takes the default value from.

> Is there another way to test if the values are being used by spamassassin?
At the end of an emails "X-Spam-Status" header. Example:

X-Spam-Status: No, score=-7.909 tagged_above=-1000 required=5
Comment 6 Jannik Ahlers univentionstaff 2018-02-22 11:46:32 CET
X-Spam-Status: No, score=-1 tagged_above=-1000 required=6
	tests=[ALL_TRUSTED=-1] autolearn=disabled

OK: values in 90_univention.cf get used
Comment 7 Stefan Gohmann univentionstaff 2018-03-14 14:38:21 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".