Bug 46290 - univention-reload-service uses sv up
univention-reload-service uses sv up
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Proxy services
UCS@school 4.2
Other Linux
: P5 normal (vote)
: UCS@school 4.2 v8
Assigned To: Daniel Tröder
Jürn Brodersen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-15 07:27 CET by Stefan Gohmann
Modified: 2018-04-06 22:09 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.091
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2018021321000668
Bug group (optional):
Max CVSS v3 score:
gohmann: Patch_Available+


Attachments
univention-reload-service.patch (370 bytes, patch)
2018-02-15 07:28 CET, Stefan Gohmann
Details | Diff
univention-reload-service.patch (825 bytes, patch)
2018-02-15 08:45 CET, Stefan Gohmann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2018-02-15 07:27:18 CET
The init script uses sv up instead of sv start. Thus, it happens that the service is not listed as started on slow systems.

In addition, the service should require the start of univention-runit.
Comment 1 Stefan Gohmann univentionstaff 2018-02-15 07:28:30 CET
Created attachment 9388 [details]
univention-reload-service.patch
Comment 2 Stefan Gohmann univentionstaff 2018-02-15 08:45:53 CET
Created attachment 9389 [details]
univention-reload-service.patch
Comment 3 Daniel Tröder univentionstaff 2018-02-15 09:10:34 CET
"service univention-reload-service stop" and "service univention-reload-service restart" didn't work at all...

* patch applied
* also s/down/stop/
* added package dependency (on univention-runit)
* merged to 4.3

[4.2 3793a064] Bug #46290: give runsv time to recognize process state
[4.2 423207e7] Bug #46290: changelog, advisory
[4.3 9339fe1d] Bug #46290: give runsv time to recognize process state
               (cherry picked from commit 3793a06)
[4.3 cdc1452e] Bug #46290: changelog
[4.2 0bb18fdd] Bug #46290: advisory update

ucs-school-webproxy (13.0.1-2)
ucs-school-webproxy (14.0.0-3)
Comment 4 Stefan Gohmann univentionstaff 2018-02-16 13:49:28 CET
It looks like we need for the customer and the slow systems to increase the sv timeout from 7 to 30 seconds. Can you change the line 
 sv start univention-reload-service
to
 sv -w 30 start univention-reload-service
?
Comment 5 Daniel Tröder univentionstaff 2018-02-19 14:37:51 CET
[4.2 3d93de04] Bug #46290: raise timeout to 30s
[4.2 4a07b30b] Bug #46290: copyright
[4.2 fe0a58f5] Bug #46290: advisory update

[4.3 cfad674e] Bug #46290: raise timeout to 30s

ucs-school-webproxy (13.0.1-4)
ucs-school-webproxy (14.0.0-4)
Comment 6 Jürn Brodersen univentionstaff 2018-02-20 18:18:22 CET
What I tested:
systemctl stop univention-reload-service.service -> OK
systemctl start univention-reload-service.service -> OK
systemctl restart univention-reload-service.service -> OK

yaml -> OK
Comment 7 Sönke Schwardt-Krummrich univentionstaff 2018-04-06 22:09:02 CEST
UCS@school 4.2 v8 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.2v8-de.html

If this error occurs again, please clone this bug.