Bug 46341 - App Center 4.3 - apt-get error handling
App Center 4.3 - apt-get error handling
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Dirk Wiesenthal
Felix Botner
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-20 11:56 CET by Felix Botner
Modified: 2018-03-14 14:38 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2018-02-20 11:56:52 CET
we have to decide whether install/upgrade/remove apt-get errors just print a generic error message or if we want a more detailed error (std err of apt-get)

and 20_appcenter.79_umc_broken_failure_error_exit_code.test has to modified accordingly
Comment 1 Dirk Wiesenthal univentionstaff 2018-02-26 12:53:34 CET
Fixed it in ucs-test. The problem was that an earlier test did not clean up its repository. But the local App Center was removed, so we got 404 and apt-get update returned with non-zero.

This is a consequence of aborting when the uninstallation of an App fails. I still think it is fine.
Comment 2 Dirk Wiesenthal univentionstaff 2018-02-26 12:58:28 CET
Whoops, this was the wrong test... But it seems fixed anyway :)
Comment 3 Felix Botner univentionstaff 2018-02-26 16:09:30 CET
In UMC is see only


Bestätigung
Ein Fehler ist aufgetreten: Failed to install the App

at least a reference to the appcenter.log would be nice.
Comment 4 Dirk Wiesenthal univentionstaff 2018-03-01 10:50:40 CET
Fixed in
  univention-appcenter 7.0.1-22A~4.3.0.201803011043

Would be complicated to fix it in the backend as the error handling there is quite exhaustive and does not let us change the message for UMC.
(For the CLI, this sentence does not make much sense. While appcenter.log contains the information, so does the output on the terminal)

So I added the hint in JS. In some cases (more than one error), this might not look too beautiful, but this should not happen often and even then it should be okay-ish. In the same JS function there is a case where we point to umc-appcenter.log. I did not change it because a DC Backup may not be at 4.3 at the time. Also, umc-appcenter.log should contain enough information, too.

No test should need modifications AFAICS.
Comment 5 Felix Botner univentionstaff 2018-03-02 12:18:44 CET
(In reply to Dirk Wiesenthal from comment #4)
> Fixed in
>   univention-appcenter 7.0.1-22A~4.3.0.201803011043
> 
> Would be complicated to fix it in the backend as the error handling there is
> quite exhaustive and does not let us change the message for UMC.
> (For the CLI, this sentence does not make much sense. While appcenter.log
> contains the information, so does the output on the terminal)
> 
> So I added the hint in JS. In some cases (more than one error), this might
> not look too beautiful, but this should not happen often and even then it
> should be okay-ish. In the same JS function there is a case where we point
> to umc-appcenter.log. I did not change it because a DC Backup may not be at
> 4.3 at the time. Also, umc-appcenter.log should contain enough information,
> too.
> 
> No test should need modifications AFAICS.

ok
Comment 6 Stefan Gohmann univentionstaff 2018-03-14 14:38:07 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".