Bug 46460 - prevent unnecessary error message upgrading to 4.3
prevent unnecessary error message upgrading to 4.3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Mail
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Daniel Tröder
Sönke Schwardt-Krummrich
: interim-3
Depends on:
Blocks: 45968 47117
  Show dependency treegraph
 
Reported: 2018-03-02 10:13 CET by Daniel Tröder
Modified: 2018-06-04 08:29 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Release Management
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2018-03-02 10:13:13 CET
+++ This bug was initially created as a clone of Bug #45968 +++

When /etc/postfix/dynamicmaps.cf doesn't exist, a unnecessary error message is shown:

--------------------------------------------------------------------
Do you want to continue [Y/n]? 

Checking for space on /var/cache/apt/archives: OK
Checking for space on /boot: OK
Checking for space on /: OK
Checking for package status: OK
Checking LDAP schema: OK
grep: /etc/postfix/dynamicmaps.cf: Datei oder Verzeichnis nicht gefunden

Starting update process, this may take a while.
Check /var/log/univention/updater.log for more information.
--------------------------------------------------------------------

Check for the files existence before grep'ing in it.
Comment 1 Daniel Tröder univentionstaff 2018-03-02 10:18:14 CET
[4.3-0 1d2c3e9536] Bug #46460: prevent error message if file doesn't exist

univention-updater (13.0.1-27)
Comment 2 Sönke Schwardt-Krummrich univentionstaff 2018-03-04 21:43:01 CET
As discussed "if [ -f FILENAME ] ; then" whould be much nicer since "-a" is a bashism and not compatible e.g. with /bin/dash.
But in bash "-a" == "-f" → ok for now, since the shebang is set to /bin/bash.

OK: code change
OK: functional change
Comment 3 Stefan Gohmann univentionstaff 2018-03-14 14:37:57 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".